Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(734)

Issue 2617553002: DevTools: Split Timeline started UMA metric into two parts. (Closed)

Created:
3 years, 11 months ago by alph
Modified:
3 years, 11 months ago
Reviewers:
Ilya Sherman, jwd, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, asvitkine+watch_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Split Timeline started UMA metric into two parts. "Timeline recording" (as it was previously) and "Timeline recording for page reload". Review-Url: https://codereview.chromium.org/2617553002 Cr-Commit-Position: refs/heads/master@{#442137} Committed: https://chromium.googlesource.com/chromium/src/+/262ca70f588b5e78be242c939405807876b90bab

Patch Set 1 #

Patch Set 2 : update the test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/inspector/user-metrics-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/host/UserMetrics.js View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js View 1 chunk +1 line, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
alph
ptal
3 years, 11 months ago (2017-01-04 19:55:24 UTC) #2
pfeldman
lgtm
3 years, 11 months ago (2017-01-04 20:15:15 UTC) #3
alph
Ilya, could you please take a look. Thanks
3 years, 11 months ago (2017-01-05 20:24:07 UTC) #5
jwd
histograms LGTM
3 years, 11 months ago (2017-01-06 15:19:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2617553002/1
3 years, 11 months ago (2017-01-06 16:45:00 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/366156)
3 years, 11 months ago (2017-01-06 18:13:37 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2617553002/20001
3 years, 11 months ago (2017-01-06 23:50:41 UTC) #13
commit-bot: I haz the power
3 years, 11 months ago (2017-01-07 02:04:04 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/262ca70f588b5e78be242c939405...

Powered by Google App Engine
This is Rietveld 408576698