Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Unified Diff: chrome/browser/resources/settings/appearance_page/appearance_page.html

Issue 2617533003: MD Settings: change most checkboxes to toggles (leave dialogs alone) (Closed)
Patch Set: fix tests Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/appearance_page/appearance_page.html
diff --git a/chrome/browser/resources/settings/appearance_page/appearance_page.html b/chrome/browser/resources/settings/appearance_page/appearance_page.html
index 14179aae8210ce2c496f4a628605701005e737eb..b945c8fc4e655f93da81b26c06849b5c035b550d 100644
--- a/chrome/browser/resources/settings/appearance_page/appearance_page.html
+++ b/chrome/browser/resources/settings/appearance_page/appearance_page.html
@@ -11,6 +11,7 @@
<link rel="import" href="/controls/settings_dropdown_menu.html">
<link rel="import" href="/controls/settings_input.html">
<link rel="import" href="/controls/settings_radio_group.html">
+<link rel="import" href="/controls/settings_toggle_button.html">
<link rel="import" href="/route.html">
<link rel="import" href="/settings_page/settings_animated_pages.html">
<link rel="import" href="/settings_page/settings_subpage.html">
@@ -90,11 +91,12 @@
</div>
<div class="settings-box"
hidden="[[!pageVisibility.homeButton]]">
- <settings-checkbox class="start" label="$i18n{showHomeButton}"
+ <settings-toggle-button class="start"
+ pref="{{prefs.browser.show_home_button}}"
+ label="$i18n{showHomeButton}"
sub-label="[[getShowHomeSubLabel_(
- prefs.homepage_is_newtabpage.value, prefs.homepage.value)]]"
- pref="{{prefs.browser.show_home_button}}">
- </settings-checkbox>
+ prefs.homepage_is_newtabpage.value, prefs.homepage.value)]]">
+ </settings-toggle-button>
</div>
<template is="dom-if" if="[[prefs.browser.show_home_button.value]]">
<div class="list-frame"
@@ -130,15 +132,18 @@
</template>
<div class="settings-box"
hidden="[[!pageVisibility.bookmarksBar]]">
- <settings-checkbox class="start" label="$i18n{showBookmarksBar}"
- pref="{{prefs.bookmark_bar.show_on_all_tabs}}">
- </settings-checkbox>
+ <settings-toggle-button class="start"
+ pref="{{prefs.bookmark_bar.show_on_all_tabs}}"
+ label="$i18n{showBookmarksBar}">
+ </settings-toggle-button>
</div>
<div class$="settings-box [[getFirst_(pageVisibility.bookmarksBar)]]">
<if expr="is_linux and not chromeos">
- <settings-checkbox class="start" label="$i18n{showWindowDecorations}"
- pref="{{prefs.browser.custom_chrome_frame}}" inverted>
- </settings-checkbox>
+ <settings-toggle-button class="start"
+ pref="{{prefs.browser.custom_chrome_frame}}"
+ label="$i18n{showWindowDecorations}"
+ inverted>
+ </settings-toggle-button>
</div>
<div class="settings-box">
</if>

Powered by Google App Engine
This is Rietveld 408576698