chrome/browser/resources/settings/android_apps_page/android_apps_page.js - Issue 2617533003: MD Settings: change most checkboxes to toggles (leave dialogs alone)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/android_apps_page/android_apps_page.js

Issue 2617533003: MD Settings: change most checkboxes to toggles (leave dialogs alone) (Closed)

Patch Set: fix tests Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/android_apps_page/android_apps_page.html ('k') | chrome/browser/resources/settings/appearance_page/appearance_page.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/android_apps_page/android_apps_page.js

diff --git a/chrome/browser/resources/settings/android_apps_page/android_apps_page.js b/chrome/browser/resources/settings/android_apps_page/android_apps_page.js

index 44ece83b48f8618a2d34fe5a8d954d5285bb9d82..9ac62e65b1321684e793b94a267472e80b927d7f 100644

--- a/chrome/browser/resources/settings/android_apps_page/android_apps_page.js

+++ b/chrome/browser/resources/settings/android_apps_page/android_apps_page.js

@@ -87,8 +87,7 @@ Polymer({

* @private

onConfirmDisableDialogConfirm_: function() {

- /** @type {!SettingsCheckboxElement} */ (this.$.enabledCheckbox)

- .sendPrefChange();

+ /** @type {!SettingsCheckboxElement} */ (this.$.enabled).sendPrefChange();

this.$.confirmDisableDialog.close();

@@ -98,8 +97,7 @@ Polymer({

* @private

onConfirmDisableDialogCancel_: function() {

- /** @type {!SettingsCheckboxElement} */ (this.$.enabledCheckbox)

- .resetToPrefValue();

+ /** @type {!SettingsCheckboxElement} */ (this.$.enabled).resetToPrefValue();

this.$.confirmDisableDialog.close();

});