Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(724)

Unified Diff: chrome/browser/resources/settings/downloads_page/downloads_page.html

Issue 2617533003: MD Settings: change most checkboxes to toggles (leave dialogs alone) (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/downloads_page/downloads_page.html
diff --git a/chrome/browser/resources/settings/downloads_page/downloads_page.html b/chrome/browser/resources/settings/downloads_page/downloads_page.html
index 4271241ee9873adead1e3dd1e3e2e792a7bdde07..450fde5b4afef5bb8593d144d8e93bcd7f4d7474 100644
--- a/chrome/browser/resources/settings/downloads_page/downloads_page.html
+++ b/chrome/browser/resources/settings/downloads_page/downloads_page.html
@@ -1,12 +1,16 @@
<link rel="import" href="chrome://resources/html/polymer.html">
<link rel="import" href="chrome://resources/polymer/v1_0/iron-flex-layout/classes/iron-flex-layout.html">
<link rel="import" href="/controls/controlled_button.html">
-<link rel="import" href="/controls/settings_checkbox.html">
+<link rel="import" href="/controls/settings_toggle_button.html">
<link rel="import" href="/settings_shared_css.html">
<dom-module id="settings-downloads-page">
<template>
- <style include="settings-shared"></style>
+ <style include="settings-shared">
+ .secondary-action {
+ text-align: end;
+ }
+ </style>
<div class="settings-box first two-line">
<div class="start">
<div>$i18n{downloadLocation}</div>
@@ -17,20 +21,23 @@
<div class="secondary-action">
<controlled-button class="secondary-button" id="changeDownloadsPath"
on-tap="selectDownloadLocation_"
- pref="[[prefs.download.default_directory]]">
+ pref="[[prefs.download.default_directory]]"
+ right-justified>
dschuyler 2017/01/05 20:25:05 Will this work well in RTL?
Dan Beam 2017/01/06 02:45:29 yes, renamed in https://codereview.chromium.org/26
$i18n{changeDownloadLocation}
</controlled-button>
</div>
</div>
<div class="settings-box block">
- <settings-checkbox pref="{{prefs.download.prompt_for_download}}"
+ <settings-toggle-button
+ pref="{{prefs.download.prompt_for_download}}"
label="$i18n{promptForDownload}">
- </settings-checkbox>
+ </settings-toggle-button>
<if expr="chromeos">
- <settings-checkbox pref="{{prefs.gdata.disabled}}"
+ <settings-toggle-button
+ pref="{{prefs.gdata.disabled}}"
label="$i18n{disconnectGoogleDriveAccount}"
hidden="[[!pageVisibility.googleDrive]]">
- </settings-checkbox>
+ </settings-toggle-button>
</if>
</div>
</template>

Powered by Google App Engine
This is Rietveld 408576698