Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(783)

Side by Side Diff: chrome/browser/resources/settings/downloads_page/downloads_page.html

Issue 2617533003: MD Settings: change most checkboxes to toggles (leave dialogs alone) (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <link rel="import" href="chrome://resources/html/polymer.html"> 1 <link rel="import" href="chrome://resources/html/polymer.html">
2 <link rel="import" href="chrome://resources/polymer/v1_0/iron-flex-layout/classe s/iron-flex-layout.html"> 2 <link rel="import" href="chrome://resources/polymer/v1_0/iron-flex-layout/classe s/iron-flex-layout.html">
3 <link rel="import" href="/controls/controlled_button.html"> 3 <link rel="import" href="/controls/controlled_button.html">
4 <link rel="import" href="/controls/settings_checkbox.html"> 4 <link rel="import" href="/controls/settings_toggle_button.html">
5 <link rel="import" href="/settings_shared_css.html"> 5 <link rel="import" href="/settings_shared_css.html">
6 6
7 <dom-module id="settings-downloads-page"> 7 <dom-module id="settings-downloads-page">
8 <template> 8 <template>
9 <style include="settings-shared"></style> 9 <style include="settings-shared">
10 .secondary-action {
11 text-align: end;
12 }
13 </style>
10 <div class="settings-box first two-line"> 14 <div class="settings-box first two-line">
11 <div class="start"> 15 <div class="start">
12 <div>$i18n{downloadLocation}</div> 16 <div>$i18n{downloadLocation}</div>
13 <div class="secondary"> 17 <div class="secondary">
14 [[getDownloadLocation_(prefs.download.default_directory.value)]] 18 [[getDownloadLocation_(prefs.download.default_directory.value)]]
15 </div> 19 </div>
16 </div> 20 </div>
17 <div class="secondary-action"> 21 <div class="secondary-action">
18 <controlled-button class="secondary-button" id="changeDownloadsPath" 22 <controlled-button class="secondary-button" id="changeDownloadsPath"
19 on-tap="selectDownloadLocation_" 23 on-tap="selectDownloadLocation_"
20 pref="[[prefs.download.default_directory]]"> 24 pref="[[prefs.download.default_directory]]"
25 right-justified>
dschuyler 2017/01/05 20:25:05 Will this work well in RTL?
Dan Beam 2017/01/06 02:45:29 yes, renamed in https://codereview.chromium.org/26
21 $i18n{changeDownloadLocation} 26 $i18n{changeDownloadLocation}
22 </controlled-button> 27 </controlled-button>
23 </div> 28 </div>
24 </div> 29 </div>
25 <div class="settings-box block"> 30 <div class="settings-box block">
26 <settings-checkbox pref="{{prefs.download.prompt_for_download}}" 31 <settings-toggle-button
32 pref="{{prefs.download.prompt_for_download}}"
27 label="$i18n{promptForDownload}"> 33 label="$i18n{promptForDownload}">
28 </settings-checkbox> 34 </settings-toggle-button>
29 <if expr="chromeos"> 35 <if expr="chromeos">
30 <settings-checkbox pref="{{prefs.gdata.disabled}}" 36 <settings-toggle-button
37 pref="{{prefs.gdata.disabled}}"
31 label="$i18n{disconnectGoogleDriveAccount}" 38 label="$i18n{disconnectGoogleDriveAccount}"
32 hidden="[[!pageVisibility.googleDrive]]"> 39 hidden="[[!pageVisibility.googleDrive]]">
33 </settings-checkbox> 40 </settings-toggle-button>
34 </if> 41 </if>
35 </div> 42 </div>
36 </template> 43 </template>
37 <script src="downloads_page.js"></script> 44 <script src="downloads_page.js"></script>
38 </dom-module> 45 </dom-module>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698