MD Settings: change most checkboxes to toggles (leave dialogs alone)

chrome/browser/resources/settings/privacy_page/privacy_page.html

 <link rel="import" href="chrome://resources/html/polymer.html">
 <link rel="import" href="chrome://resources/cr_elements/policy/cr_policy_vars_css.html">
 <link rel="import" href="chrome://resources/html/web_ui_listener_behavior.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/iron-flex-layout/iron-flex-layout-classes.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/neon-animation/neon-animatable.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-button.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper-icon-button-light.html">
+<link rel="import" href="chrome://resources/polymer/v1_0/paper-toggle-button/paper-toggle-button.html">
 <link rel="import" href="/clear_browsing_data_dialog/clear_browsing_data_dialog.html">
-<link rel="import" href="/controls/settings_checkbox.html">
 <link rel="import" href="/controls/settings_toggle_button.html">
 <link rel="import" href="/lifetime_browser_proxy.html">
 <link rel="import" href="/route.html">
 <link rel="import" href="/settings_page/settings_animated_pages.html">
 <link rel="import" href="/settings_page/settings_subpage.html">
 <link rel="import" href="/settings_shared_css.html">
 <link rel="import" href="/site_settings/all_sites.html">
 <link rel="import" href="/site_settings/category_default_setting.html">
 <link rel="import" href="/site_settings/category_setting_exceptions.html">
 <link rel="import" href="/site_settings/constants.html">
@@ skipping 11 matching lines @@
 </if>
 <link rel="import" href="/privacy_page/privacy_page_browser_proxy.html">
 
 <dom-module id="settings-privacy-page">
   <template>
     <style include="settings-shared">
       button[is='paper-icon-button-light'].icon-help {
         background-image: url(../images/help_outline.svg);
       }
 
-      /* TODO(dbeam): this is similar to a 1 line checkbox. Worth somehow
-       * combining? */
-      #metricsReporting,
-      #safeBrowsingExtendedReporting {
-        align-items: center;
-        display: flex;
+      .settings-row-min-height {
         min-height: var(--settings-row-min-height);
       }

[Dan Beam, 2017/01/06 02:45:30]

this is being shrunk here: https://codereview.chromium.org/2614063004

 
-      #metricsReportingCheckbox,
-      #safeBrowsingExtendedReportingCheckbox {
-        display: inline-block;
-      }
-
-      #metricsReportingCheckbox:not([disabled]),
-      #safeBrowsingExtendedReportingCheckbox {
-        width: 100%;
-      }
-
-      #metricsReporting paper-tooltip {
-        --paper-tooltip: var(--cr-policy-tooltip);
-      }
-
-      #indicator {
-        -webkit-margin-start: var(--checkbox-spacing);
-      }
-
       #restart {
-        flex: 1;
         text-align: end;
       }
     </style>
     <template is="dom-if" if="[[showClearBrowsingDataDialog_]]" restamp>
       <settings-clear-browsing-data-dialog prefs="{{prefs}}"
           on-close="onDialogClosed_">
       </settings-clear-browsing-data-dialog>
     </template>
     <settings-animated-pages id="pages" section="privacy">
       <neon-animatable route-path="default">
         <div class="settings-box block first">
           <p class="privacy-explanation">$i18nRaw{improveBrowsingExperience}</p>
-          <settings-checkbox pref="{{prefs.alternate_error_pages.enabled}}"
+          <settings-toggle-button
+              pref="{{prefs.alternate_error_pages.enabled}}"
               label="$i18n{linkDoctorPref}">
-          </settings-checkbox>
-          <settings-checkbox pref="{{prefs.search.suggest_enabled}}"
+          </settings-toggle-button>
+          <settings-toggle-button
+              pref="{{prefs.search.suggest_enabled}}"
               label="$i18n{searchSuggestPref}"
               hidden="[[!pageVisibility.searchPrediction]]">
-          </settings-checkbox>
-          <settings-checkbox pref="{{prefs.net.network_prediction_options}}"
+          </settings-toggle-button>

[dschuyler, 2017/01/05 20:25:05]

Afaik, each toggle would be within a .settings-box div. I just checked with Alan
whom agreed that for now they should have a grey line to indicate the rows (aka,
putting them in a .settings-box). The screen shot I sent the other day shows how
they look with the grey lines (that's the screen shot I asked Alan about).

[Dan Beam, 2017/01/06 02:45:30]

let's do that separately because i don't agree

[dschuyler, 2017/01/10 00:07:53]

There was a separate email thread about this, was Alan able to sway the choice
on row lines?

[Dan Beam, 2017/01/11 01:55:48]

yes, but we're doing this after

+          <settings-toggle-button
+              pref="{{prefs.net.network_prediction_options}}"
               label="$i18n{networkPredictionEnabled}"
               hidden="[[!pageVisibility.networkPrediction]]">
-          </settings-checkbox>
-          <div id="safeBrowsingExtendedReporting">
-            <paper-checkbox id="safeBrowsingExtendedReportingCheckbox"
-                on-tap="onSafeBrowsingExtendedReportingCheckboxTap_"
+          </settings-toggle-button>
+          <div class="layout horizontal center settings-row-min-height">
+            <div class="flex">$i18n{safeBrowsingEnableExtendedReporting}</div>
+            <paper-toggle-button
+                id="safeBrowsingExtendedReportingControl"
+                on-tap="onSafeBrowsingExtendedReportingControlTap_"
                 checked="[[safeBrowsingExtendedReportingEnabled_]]">
-              $i18n{safeBrowsingEnableExtendedReporting}
-            </paper-checkbox>
+            </paper-toggle-button>
           </div>

[dschuyler, 2017/01/05 20:25:05]

The div above could probably be converted changed to look more like the other
settings-toggle-button's on this page (with the label="" and such).

[Dan Beam, 2017/01/06 02:45:30]

<paper-toggle-button> doesn't have label= property and the <content> slot is on
the wrong side (<paper-toggle-button> shows toggle on the left, label on the
right)

-          <settings-checkbox pref="{{prefs.safebrowsing.enabled}}"
+          <settings-toggle-button
+              pref="{{prefs.safebrowsing.enabled}}"
               label="$i18n{safeBrowsingEnableProtection}">
-          </settings-checkbox>
+          </settings-toggle-button>
 <if expr="_google_chrome">
 <if expr="chromeos">
-          <settings-checkbox pref="{{prefs.cros.metrics.reportingEnabled}}"
+          <settings-toggle-button
+              pref="{{prefs.cros.metrics.reportingEnabled}}"
               label="$i18n{enableLogging}">
-          </settings-checkbox>
+          </settings-toggle-button>
 </if><!-- chromeos -->
 <if expr="not chromeos">
-          <div id="metricsReporting">
-            <paper-checkbox id="metricsReportingCheckbox"
-                on-tap="onMetricsReportingCheckboxTap_"
-                checked="[[metricsReporting_.enabled]]"
-                disabled="[[metricsReporting_.managed]]">
-              $i18n{enableLogging}
-            </paper-checkbox>
+          <div class="layout horizontal center settings-row-min-height">
+            <div class="flex">$i18n{enableLogging}</div>
+            <template is="dom-if" if="[[showRestart_]]" restamp>
+              <div class="flex" id="restart">
+                <paper-button on-tap="onRestartTap_">
+                  $i18n{restart}
+                </paper-button>
+              </div>
+            </template>
             <template is="dom-if" if="[[metricsReporting_.managed]]" restamp>
               <iron-icon id="indicator" tabindex=0 icon="cr:domain"></iron-icon>
               <paper-tooltip for="indicator" position="top"
                   fit-to-visible-bounds>
                 $i18n{controlledSettingPolicy}
               </paper-tooltip>
             </template>
-            <template is="dom-if" if="[[showRestart_]]" restamp>
-              <div id="restart">
-                <paper-button on-tap="onRestartTap_">
-                  $i18n{restart}
-                </paper-button>
-              </div>
-            </template>
+            <paper-toggle-button
+                on-tap="onMetricsReportingControlTap_"
+                checked="[[metricsReporting_.enabled]]"
+                disabled="[[metricsReporting_.managed]]">

[dschuyler, 2017/01/05 20:25:05]

Could the label from line 93 be made a label="" here and then then templates
could be put in a div and slotted into the toggle button with the .more-actions
selector (similar to another change in this CL)?

[Dan Beam, 2017/01/06 02:45:30]

paper-toggle-button != settings-toggle-button

+            </paper-toggle-button>
           </div>
 </if><!-- not chromeos -->
 </if><!-- _google_chrome -->
-          <settings-checkbox pref="{{prefs.enable_do_not_track}}"
+          <settings-toggle-button
+              pref="{{prefs.enable_do_not_track}}"
               label="$i18n{doNotTrack}">
-          </settings-checkbox>
+          </settings-toggle-button>
 <if expr="chromeos">
-          <settings-checkbox
+          <settings-toggle-button
               pref="{{prefs.cros.device.attestation_for_content_protection_enabled}}"
               label="$i18n{enableContentProtectionAttestation}">
-          </settings-checkbox>
-          <settings-checkbox
+          </settings-toggle-button>
+          <settings-toggle-button
               pref="{{prefs.settings.internet.wake_on_wifi_darkconnect}}"
               label="$i18n{wakeOnWifi}">
-          </settings-checkbox>
+          </settings-toggle-button>
 </if>
         </div>
 <if expr="_google_chrome">
         <div class="settings-box two-line">
           <settings-toggle-button class="start"
               pref="{{prefs.spellcheck.use_spelling_service}}"
               label="$i18n{spellingPref}"
               sub-label="$i18n{spellingDescription}">
           </settings-toggle-button>
         </div>
@@ skipping 239 matching lines @@
             $i18n{siteSettingsCookieRemoveAll}
           </paper-button>
           <site-data-details-subpage page-title="{{pageTitle}}">
           </site-data-details-subpage>
         </settings-subpage>
       </template>
     </settings-animated-pages>
   </template>
   <script src="privacy_page.js"></script>
 </dom-module>