Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Issue 2617493003: [Android] Fix overzealous autocomplete removal in the omnibox. (Closed)

Created:
3 years, 11 months ago by Ted C
Modified:
3 years, 11 months ago
Reviewers:
Maria
CC:
chromium-reviews, jdonnelly+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Fix overzealous autocomplete removal in the omnibox. To work around crbug.com/273763, we were previously removing all text after the selection end if the selection range was entirely before the autocomplete text. On certain keyboards, this could result in deleting new user text that differs from the previously autcompleted text. Now, we only clear the text if it matches the autocompleted text. I verified that this fix did not regress the HTC issue (tested on 4.2.2 w/ the Sense keyboard), and it also address the Japanese IME issue mentioned in the new bug. BUG=569144 Committed: https://crrev.com/1cfb88255b2a5d921d7ca605e0067d7acd231c2a Cr-Commit-Position: refs/heads/master@{#441495}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/omnibox/UrlBar.java View 10 chunks +30 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Ted C
PTAL Also, this adds debugging info that I add every time I investigate one of ...
3 years, 11 months ago (2017-01-04 21:48:58 UTC) #2
Maria
lgtm
3 years, 11 months ago (2017-01-04 21:58:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2617493003/1
3 years, 11 months ago (2017-01-04 22:01:33 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2017-01-04 22:40:38 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-04 22:42:47 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1cfb88255b2a5d921d7ca605e0067d7acd231c2a
Cr-Commit-Position: refs/heads/master@{#441495}

Powered by Google App Engine
This is Rietveld 408576698