Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 2617493002: Revert "Show user menu on right-click of the avatar button when MaterialDesignUserMenu is enabled." (Closed)

Created:
3 years, 11 months ago by msarda
Modified:
3 years, 11 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Show user menu on right-click of the avatar button when MaterialDesignUserMenu is enabled." This reverts commit 6b24b79eb930b4abb10451a77489528325a8bd63. The reason for this revert is that we want to remove the right-click behavior from new user menu. BUG=661289 Committed: https://crrev.com/cee1ec7ce52f4483b5277ff04ef22ad125618fb7 Cr-Commit-Position: refs/heads/master@{#441403}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -13 lines) Patch
M chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm View 2 chunks +7 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/profiles/profile_chooser_view.cc View 1 chunk +4 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
msarda
Please take a look.
3 years, 11 months ago (2017-01-04 14:09:52 UTC) #2
sky
LGTM
3 years, 11 months ago (2017-01-04 16:40:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2617493002/1
3 years, 11 months ago (2017-01-04 16:47:42 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2017-01-04 17:49:02 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-04 17:51:11 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cee1ec7ce52f4483b5277ff04ef22ad125618fb7
Cr-Commit-Position: refs/heads/master@{#441403}

Powered by Google App Engine
This is Rietveld 408576698