Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issue 2617483005: use unique_ptr in cxfa_layoutprocessor.h (Closed)

Created:
3 years, 11 months ago by Tom Sepez
Modified:
3 years, 11 months ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Unused method #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -27 lines) Patch
M xfa/fxfa/parser/cxfa_layoutprocessor.h View 1 2 chunks +10 lines, -9 lines 0 comments Download
M xfa/fxfa/parser/cxfa_layoutprocessor.cpp View 1 5 chunks +9 lines, -18 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Tom Sepez
Dan, for review.
3 years, 11 months ago (2017-01-05 23:31:15 UTC) #2
dsinclair
lgtm
3 years, 11 months ago (2017-01-06 02:45:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2617483005/20001
3 years, 11 months ago (2017-01-06 02:45:30 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-06 03:21:42 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/469f6da247ffe77d0ae6089e5d93db0b0c0b...

Powered by Google App Engine
This is Rietveld 408576698