Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 2617433005: Null-check scrollable area when invalidating sticky constraints. (Closed)

Created:
3 years, 11 months ago by chrishtr
Modified:
3 years, 11 months ago
Reviewers:
wkorman
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Null-check scrollable area when invalidating sticky constraints. BUG=678452 Review-Url: https://codereview.chromium.org/2617433005 Cr-Commit-Position: refs/heads/master@{#441983} Committed: https://chromium.googlesource.com/chromium/src/+/ba85a156e1974f8efabe02594e2abf23726a9462

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
chrishtr
3 years, 11 months ago (2017-01-06 00:45:12 UTC) #3
wkorman
lgtm
3 years, 11 months ago (2017-01-06 02:42:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2617433005/1
3 years, 11 months ago (2017-01-06 16:38:37 UTC) #6
commit-bot: I haz the power
3 years, 11 months ago (2017-01-06 18:28:13 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ba85a156e1974f8efabe02594e2a...

Powered by Google App Engine
This is Rietveld 408576698