Use the standard downcasting macros for downcasting TextTrack objects.

Use the standard downcasting macros for downcasting TextTrack objects.

Though clusterfuzz uses ubsan now, which should catch bad casts, using
these macros is still the typical convention for Blink code that needs
to downcast.

BUG=none

Committed: https://crrev.com/be820b8ee970fe4bf17804821046890a9e77169f
Cr-Commit-Position: refs/heads/master@{#441453}

[dcheng, 2017-01-04 04:58:07]

The CQ bit was checked by dcheng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-04 04:58:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dcheng, 2017-01-04 04:58:24]

dcheng@chromium.org changed reviewers:
+ foolip@chromium.org

[commit-bot: I haz the power, 2017-01-04 06:30:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-04 06:30:24]

Dry run: This issue passed the CQ dry run.

[fs, 2017-01-04 09:44:56]

fs@opera.com changed reviewers:
+ fs@opera.com

[fs, 2017-01-04 09:44:57]

lgtm

https://codereview.chromium.org/2617433002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/track/TextTrackList.cpp (right):

https://codereview.chromium.org/2617433002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/track/TextTrackList.cpp:50: return
toLoadableTextTrack(textTrack)->trackElementIndex();
There are a few more instances like this one - could you fix those too? (One
further down in this file, and one in CueTimeline.cpp.)

[dcheng, 2017-01-04 19:09:09]

https://codereview.chromium.org/2617433002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/track/TextTrackList.cpp (right):

https://codereview.chromium.org/2617433002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/track/TextTrackList.cpp:50: return
toLoadableTextTrack(textTrack)->trackElementIndex();
On 2017/01/04 09:44:57, fs wrote:
> There are a few more instances like this one - could you fix those too? (One
> further down in this file, and one in CueTimeline.cpp.)

Done.

[dcheng, 2017-01-04 19:09:12]

The CQ bit was checked by dcheng@chromium.org

[dcheng, 2017-01-04 19:09:12]

The patchset sent to the CQ was uploaded after l-g-t-m from fs@opera.com
Link to the patchset: https://codereview.chromium.org/2617433002/#ps20001
(title: ".")

[commit-bot: I haz the power, 2017-01-04 19:09:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 20:29:04]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1483556952531590,
"parent_rev": "b4860ef947f28e5ad1101b9b75ec18ef94468186", "commit_rev":
"c49337ef00a1d17140c957da579796bd852a6389"}

[commit-bot: I haz the power, 2017-01-04 20:29:33]

Description was changed from

==========
Use the standard downcasting macros for downcasting TextTrack objects.

Though clusterfuzz uses ubsan now, which should catch bad casts, using
these macros is still the typical convention for Blink code that needs
to downcast.

BUG=none
==========

to

==========
Use the standard downcasting macros for downcasting TextTrack objects.

Though clusterfuzz uses ubsan now, which should catch bad casts, using
these macros is still the typical convention for Blink code that needs
to downcast.

BUG=none

Review-Url: https://codereview.chromium.org/2617433002
==========

[commit-bot: I haz the power, 2017-01-04 20:29:35]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2017-01-04 20:31:32]

Description was changed from

==========
Use the standard downcasting macros for downcasting TextTrack objects.

Though clusterfuzz uses ubsan now, which should catch bad casts, using
these macros is still the typical convention for Blink code that needs
to downcast.

BUG=none

Review-Url: https://codereview.chromium.org/2617433002
==========

to

==========
Use the standard downcasting macros for downcasting TextTrack objects.

Though clusterfuzz uses ubsan now, which should catch bad casts, using
these macros is still the typical convention for Blink code that needs
to downcast.

BUG=none

Committed: https://crrev.com/be820b8ee970fe4bf17804821046890a9e77169f
Cr-Commit-Position: refs/heads/master@{#441453}
==========

[commit-bot: I haz the power, 2017-01-04 20:31:33]

Patchset 2 (id:??) landed as
https://crrev.com/be820b8ee970fe4bf17804821046890a9e77169f
Cr-Commit-Position: refs/heads/master@{#441453}