Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 2617423003: [Extensions Bindings] Add support for updateArgumentsPostValidate (Closed)

Created:
3 years, 11 months ago by Devlin
Modified:
3 years, 11 months ago
Reviewers:
lazyboy, jbroman
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions Bindings] Add support for updateArgumentsPostValidate Add the support for the updateArgumentsPostValidate custom hook, and add tests for the same. BUG=653596 Review-Url: https://codereview.chromium.org/2617423003 Cr-Commit-Position: refs/heads/master@{#443412} Committed: https://chromium.googlesource.com/chromium/src/+/e1723556c1c6ab404ab7e327c4cc62f19001aa51

Patch Set 1 #

Patch Set 2 : . #

Total comments: 2

Patch Set 3 : One TryCatch #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -23 lines) Patch
M extensions/renderer/api_binding.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/renderer/api_binding_hooks.h View 1 1 chunk +8 lines, -8 lines 0 comments Download
M extensions/renderer/api_binding_hooks.cc View 1 2 7 chunks +45 lines, -13 lines 0 comments Download
M extensions/renderer/api_binding_unittest.cc View 1 2 3 1 chunk +55 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (17 generated)
Devlin
Another one for y'all.
3 years, 11 months ago (2017-01-09 21:34:56 UTC) #7
jbroman
lgtm https://codereview.chromium.org/2617423003/diff/20001/extensions/renderer/api_binding_hooks.cc File extensions/renderer/api_binding_hooks.cc (right): https://codereview.chromium.org/2617423003/diff/20001/extensions/renderer/api_binding_hooks.cc#newcode276 extensions/renderer/api_binding_hooks.cc:276: v8::TryCatch try_catch(isolate); nit: A thought here: I don't ...
3 years, 11 months ago (2017-01-11 20:01:48 UTC) #8
lazyboy
lgtm
3 years, 11 months ago (2017-01-11 21:04:16 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2617423003/60001
3 years, 11 months ago (2017-01-13 00:06:04 UTC) #19
commit-bot: I haz the power
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/e1723556c1c6ab404ab7e327c4cc62f19001aa51
3 years, 11 months ago (2017-01-13 00:37:15 UTC) #22
Devlin
3 years, 11 months ago (2017-01-13 17:11:58 UTC) #23
Message was sent while issue was closed.
(forgot to send this, it was fixed in the patch)

https://codereview.chromium.org/2617423003/diff/20001/extensions/renderer/api...
File extensions/renderer/api_binding_hooks.cc (right):

https://codereview.chromium.org/2617423003/diff/20001/extensions/renderer/api...
extensions/renderer/api_binding_hooks.cc:276: v8::TryCatch try_catch(isolate);
On 2017/01/11 20:01:48, jbroman wrote:
> nit: A thought here: I don't see any place here where we don't want to catch
> exceptions. We could probably lift the v8::TryCatch up to before the
> pre-validate hook, and just use HasCaught/ReThrow on the one TryCatch. If
there
> is any place where we do want to suppress the exception (I don't see one
here),
> we could use TryCatch::Reset.

Done.

Powered by Google App Engine
This is Rietveld 408576698