[Extensions Bindings] Add support for updateArgumentsPostValidate

[Extensions Bindings] Add support for updateArgumentsPostValidate

Add the support for the updateArgumentsPostValidate custom hook, and
add tests for the same.

BUG=653596
Review-Url: https://codereview.chromium.org/2617423003
Cr-Commit-Position: refs/heads/master@{#443412}
Committed: https://chromium.googlesource.com/chromium/src/+/e1723556c1c6ab404ab7e327c4cc62f19001aa51

[Devlin, 2017-01-09 17:05:13]

Description was changed from

==========
Update postvalidate
BUG=
==========

to

==========
[Extensions Bindings] Add support for updateArgumentsPostValidate

Add the support for the updateArgumentsPostValidate custom hook, and
add tests for the same.

BUG=653596
==========

[Devlin, 2017-01-09 17:05:19]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-09 17:06:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-09 17:58:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-09 17:58:36]

Dry run: This issue passed the CQ dry run.

[Devlin, 2017-01-09 21:34:55]

rdevlin.cronin@chromium.org changed reviewers:
+ jbroman@chromium.org, lazyboy@chromium.org

[Devlin, 2017-01-09 21:34:56]

Another one for y'all.

[jbroman, 2017-01-11 20:01:48]

lgtm

https://codereview.chromium.org/2617423003/diff/20001/extensions/renderer/api...
File extensions/renderer/api_binding_hooks.cc (right):

https://codereview.chromium.org/2617423003/diff/20001/extensions/renderer/api...
extensions/renderer/api_binding_hooks.cc:276: v8::TryCatch try_catch(isolate);
nit: A thought here: I don't see any place here where we don't want to catch
exceptions. We could probably lift the v8::TryCatch up to before the
pre-validate hook, and just use HasCaught/ReThrow on the one TryCatch. If there
is any place where we do want to suppress the exception (I don't see one here),
we could use TryCatch::Reset.

[lazyboy, 2017-01-11 21:04:16]

lgtm

[Devlin, 2017-01-12 20:39:03]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-12 20:40:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 20:51:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-12 20:51:56]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Devlin, 2017-01-12 23:18:46]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-12 23:19:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Devlin, 2017-01-13 00:04:52]

The CQ bit was unchecked by rdevlin.cronin@chromium.org

[Devlin, 2017-01-13 00:04:56]

The CQ bit was checked by rdevlin.cronin@chromium.org

[Devlin, 2017-01-13 00:04:57]

The patchset sent to the CQ was uploaded after l-g-t-m from
lazyboy@chromium.org, jbroman@chromium.org
Link to the patchset: https://codereview.chromium.org/2617423003/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2017-01-13 00:06:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 00:36:44]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1484265896459680,
"parent_rev": "9f3f2c8a92072d2e0a7194f6ebd3547c3609cb09", "commit_rev":
"e1723556c1c6ab404ab7e327c4cc62f19001aa51"}

[commit-bot: I haz the power, 2017-01-13 00:37:14]

Description was changed from

==========
[Extensions Bindings] Add support for updateArgumentsPostValidate

Add the support for the updateArgumentsPostValidate custom hook, and
add tests for the same.

BUG=653596
==========

to

==========
[Extensions Bindings] Add support for updateArgumentsPostValidate

Add the support for the updateArgumentsPostValidate custom hook, and
add tests for the same.

BUG=653596

Review-Url: https://codereview.chromium.org/2617423003
Cr-Commit-Position: refs/heads/master@{#443412}
Committed:
https://chromium.googlesource.com/chromium/src/+/e1723556c1c6ab404ab7e327c4cc...
==========

[commit-bot: I haz the power, 2017-01-13 00:37:15]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/e1723556c1c6ab404ab7e327c4cc...

[Devlin, 2017-01-13 17:11:58]

(forgot to send this, it was fixed in the patch)

https://codereview.chromium.org/2617423003/diff/20001/extensions/renderer/api...
File extensions/renderer/api_binding_hooks.cc (right):

https://codereview.chromium.org/2617423003/diff/20001/extensions/renderer/api...
extensions/renderer/api_binding_hooks.cc:276: v8::TryCatch try_catch(isolate);
On 2017/01/11 20:01:48, jbroman wrote:
> nit: A thought here: I don't see any place here where we don't want to catch
> exceptions. We could probably lift the v8::TryCatch up to before the
> pre-validate hook, and just use HasCaught/ReThrow on the one TryCatch. If
there
> is any place where we do want to suppress the exception (I don't see one
here),
> we could use TryCatch::Reset.

Done.