Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 2617413002: [TurboFan] Reduce zone memory usage in register-allocator-verifier. (Closed)

Created:
3 years, 11 months ago by rmcilroy
Modified:
3 years, 11 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[TurboFan] Reduce zone memory usage in register-allocator-verifier. Avoid allocating local objects in the outer zone, instead create a new inner zone in ValidatePendingAssessment. BUG=v8:5796 Review-Url: https://codereview.chromium.org/2617413002 Cr-Commit-Position: refs/heads/master@{#42151} Committed: https://chromium.googlesource.com/v8/v8/+/f377d9f364e5520b3e7257ce4404cf69737e61ae

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M src/compiler/register-allocator-verifier.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
rmcilroy
Benedikt, PTAL thanks.
3 years, 11 months ago (2017-01-09 14:19:59 UTC) #4
Benedikt Meurer
lgtm
3 years, 11 months ago (2017-01-09 18:27:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2617413002/1
3 years, 11 months ago (2017-01-09 18:31:04 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-09 18:32:50 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/f377d9f364e5520b3e7257ce4404cf69737...

Powered by Google App Engine
This is Rietveld 408576698