Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2617403004: [MD Settings] Fix spacing and ripple for passwords section. (Closed)

Created:
3 years, 11 months ago by hcarmona
Modified:
3 years, 11 months ago
Reviewers:
dschuyler
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD Settings] Fix spacing and ripple for passwords section. Screenshot in bug. BUG=609160 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2617403004 Cr-Commit-Position: refs/heads/master@{#442383} Committed: https://chromium.googlesource.com/chromium/src/+/dc55ca6a8ab2daee62837eba062cdba8bae4d4da

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -7 lines) Patch
M chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/passwords_and_forms_page/passwords_shared_css.html View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
hcarmona
PTAL
3 years, 11 months ago (2017-01-09 17:56:51 UTC) #5
dschuyler
lgtm
3 years, 11 months ago (2017-01-09 22:03:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2617403004/1
3 years, 11 months ago (2017-01-09 22:26:28 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-09 22:46:08 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/dc55ca6a8ab2daee62837eba062c...

Powered by Google App Engine
This is Rietveld 408576698