Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2617403002: Media Session: remove EventTarget from MediaSession interface inheritance. (Closed)

Created:
3 years, 11 months ago by mlamouri (slow - plz ping)
Modified:
3 years, 11 months ago
CC:
blink-reviews, chromium-reviews, haraken
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Media Session: remove EventTarget from MediaSession interface inheritance. Was forgotten and had interesting consequences :) BUG=679338 R=zqzhang@chromium.org Review-Url: https://codereview.chromium.org/2617403002 Cr-Commit-Position: refs/heads/master@{#442261} Committed: https://chromium.googlesource.com/chromium/src/+/06318a315afd262552ee1393cf360f4adb27223a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/mediasession/MediaSession.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (6 generated)
mlamouri (slow - plz ping)
PTAL
3 years, 11 months ago (2017-01-09 14:04:12 UTC) #3
Zhiqiang Zhang (Slow)
lgtm LGTM, Thanks :)
3 years, 11 months ago (2017-01-09 14:05:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2617403002/1
3 years, 11 months ago (2017-01-09 14:13:18 UTC) #7
commit-bot: I haz the power
3 years, 11 months ago (2017-01-09 16:27:05 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/06318a315afd262552ee1393cf36...

Powered by Google App Engine
This is Rietveld 408576698