[ios] EarlGrey tests for HTTP Authentication.

[ios] EarlGrey tests for HTTP Authentication.

Tests Logging In with correct/incorrect credentials and cancelling
authentication.

Also added cancelButton to chrome_matchers.

BUG=577395
Review-Url: https://codereview.chromium.org/2617393003
Cr-Commit-Position: refs/heads/master@{#443428}
Committed: https://chromium.googlesource.com/chromium/src/+/af0d4819e446c6615c38b018c58d82565b20716d

[Eugene But (OOO till 7-30), 2017-01-10 04:33:03]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 04:34:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Eugene But (OOO till 7-30), 2017-01-10 04:39:19]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 04:39:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 06:18:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 06:18:53]

Dry run: This issue passed the CQ dry run.

[Eugene But (OOO till 7-30), 2017-01-11 22:47:21]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[Eugene But (OOO till 7-30), 2017-01-11 22:48:11]

Description was changed from

==========
[ios] EarlGrey tests for HTTP Authentication.

Tests Logging In with correct/incorrect credentials and cancelling
authentication.

BUG=577395
==========

to

==========
[ios] EarlGrey tests for HTTP Authentication.

Tests Logging In with correct/incorrect credentials and cancelling
authentication.

Also added cancelButton to chrome_matchers.

BUG=577395
==========

[commit-bot: I haz the power, 2017-01-11 22:48:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 22:58:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 22:58:46]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[Eugene But (OOO till 7-30), 2017-01-11 23:35:11]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 23:36:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 23:48:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 23:48:27]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Eugene But (OOO till 7-30), 2017-01-11 23:54:15]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 23:55:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 01:56:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-12 01:56:31]

Dry run: This issue passed the CQ dry run.

[Eugene But (OOO till 7-30), 2017-01-12 02:36:07]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-12 02:36:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 02:46:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-12 02:46:48]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[Eugene But (OOO till 7-30), 2017-01-12 03:26:03]

eugenebut@chromium.org changed reviewers:
+ baxley@chromium.org

[baxley, 2017-01-12 23:57:18]

lgtm

https://codereview.chromium.org/2617393003/diff/220001/ios/chrome/browser/web...
File ios/chrome/browser/web/http_auth_egtest.mm (right):

https://codereview.chromium.org/2617393003/diff/220001/ios/chrome/browser/web...
ios/chrome/browser/web/http_auth_egtest.mm:141: // allows tapping dialog buttons
with active page load spinner.
Sorry if I forgot from our conversation... Disabling synchronization doesn't
help here?

https://codereview.chromium.org/2617393003/diff/220001/ios/chrome/browser/web...
ios/chrome/browser/web/http_auth_egtest.mm:174: URL, "BadRealm", "baduser",
"badpass"));
optional nit: should this these arguments start with "good", and then have the
user pass in "bad*" ?

[Eugene But (OOO till 7-30), 2017-01-13 00:05:50]

Thanks!

https://codereview.chromium.org/2617393003/diff/220001/ios/chrome/browser/web...
File ios/chrome/browser/web/http_auth_egtest.mm (right):

https://codereview.chromium.org/2617393003/diff/220001/ios/chrome/browser/web...
ios/chrome/browser/web/http_auth_egtest.mm:141: // allows tapping dialog buttons
with active page load spinner.
On 2017/01/12 23:57:18, baxley wrote:
> Sorry if I forgot from our conversation... Disabling synchronization doesn't
> help here?
No. EG can not Tap and complains about ongoing animation :(

https://codereview.chromium.org/2617393003/diff/220001/ios/chrome/browser/web...
ios/chrome/browser/web/http_auth_egtest.mm:174: URL, "BadRealm", "baduser",
"badpass"));
On 2017/01/12 23:57:18, baxley wrote:
> optional nit: should this these arguments start with "good", and then have the
> user pass in "bad*" ?
No. After successful authorization (which happens in testSuccessfullBasicAuth)
WKWebView may send old cached credentials which are gooduser/goodpass so using
good prefix will make this test flaky, because authorization will sometimes
suceed.

Requirement to change the password is described in HttpAuthResponseProvider
constructor comments.

[Eugene But (OOO till 7-30), 2017-01-13 00:05:55]

The CQ bit was checked by eugenebut@chromium.org

[commit-bot: I haz the power, 2017-01-13 00:07:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 01:19:16]

CQ is committing da patch.

Bot data: {"patchset_id": 220001, "attempt_start_ts": 1484265955816380,
"parent_rev": "68bb56a5e0c5b2e86396bc08688479cc63307f41", "commit_rev":
"af0d4819e446c6615c38b018c58d82565b20716d"}

[commit-bot: I haz the power, 2017-01-13 01:19:50]

Description was changed from

==========
[ios] EarlGrey tests for HTTP Authentication.

Tests Logging In with correct/incorrect credentials and cancelling
authentication.

Also added cancelButton to chrome_matchers.

BUG=577395
==========

to

==========
[ios] EarlGrey tests for HTTP Authentication.

Tests Logging In with correct/incorrect credentials and cancelling
authentication.

Also added cancelButton to chrome_matchers.

BUG=577395

Review-Url: https://codereview.chromium.org/2617393003
Cr-Commit-Position: refs/heads/master@{#443428}
Committed:
https://chromium.googlesource.com/chromium/src/+/af0d4819e446c6615c38b018c58d...
==========

[commit-bot: I haz the power, 2017-01-13 01:19:51]

Committed patchset #12 (id:220001) as
https://chromium.googlesource.com/chromium/src/+/af0d4819e446c6615c38b018c58d...