[stubs] Ensure generated CalculateNewElementsCapacity is identical to runtime version

[stubs] Ensure generated CalculateNewElementsCapacity is identical to runtime version

The original TF port didn't maintain the same semantics as the CS/runtime implementation, and in fact introduced a bug that grew capacity too slowly on
32-bit platforms.

R=ishell@chromium.org
LOG=N

Review-Url: https://codereview.chromium.org/2617393002
Cr-Commit-Position: refs/heads/master@{#42155}
Committed: https://chromium.googlesource.com/v8/v8/+/8e19a2c4972bb7c3aae723c37999bedd3f8343dc

[danno, 2017-01-09 13:50:57]

Description was changed from

==========
[stubs] Ensure generated CalculateNewElementsCapacity is identical to runtime
version
==========

to

==========
[stubs] Ensure generated CalculateNewElementsCapacity is identical to runtime
version

The original TF port didn't maintain the same semantics as the CS/runtime
implementation.

R=ishell@chromium.org
LOG=N
==========

[danno, 2017-01-09 13:50:57]

danno@chromium.org changed reviewers:
+ ishell@chromium.org

[danno, 2017-01-09 13:51:39]

Description was changed from

==========
[stubs] Ensure generated CalculateNewElementsCapacity is identical to runtime
version

The original TF port didn't maintain the same semantics as the CS/runtime
implementation.

R=ishell@chromium.org
LOG=N
==========

to

==========
[stubs] Ensure generated CalculateNewElementsCapacity is identical to runtime
version

The original TF port didn't maintain the same semantics as the CS/runtime
implementation, and in fact introduced a bug that grew capacity too slowly on
32-bit platforms.

R=ishell@chromium.org
LOG=N
==========

[danno, 2017-01-09 13:51:48]

The CQ bit was checked by danno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-09 13:51:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danno, 2017-01-09 13:52:48]

ptal

[commit-bot: I haz the power, 2017-01-09 13:56:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-09 13:56:07]

Dry run: Try jobs failed on following builders:
  v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...)
  v8_linux_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/18720)
  v8_win_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/20453)

[Igor Sheludko, 2017-01-09 14:53:10]

lgtm once you make the verifier happy:

https://codereview.chromium.org/2617393002/diff/1/src/code-stub-assembler.cc
File src/code-stub-assembler.cc (right):

https://codereview.chromium.org/2617393002/diff/1/src/code-stub-assembler.cc#...
src/code-stub-assembler.cc:2348: if (mode == SMI_PARAMETERS) {
Maybe it would be better to introduce WordOrSmiShr and use IntPtrOrSmiAdd here.

[danno, 2017-01-10 01:18:45]

The CQ bit was checked by danno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 01:18:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danno, 2017-01-10 01:19:38]

The CQ bit was checked by danno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 01:19:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danno, 2017-01-10 01:39:53]

feedback addressed

https://codereview.chromium.org/2617393002/diff/1/src/code-stub-assembler.cc
File src/code-stub-assembler.cc (right):

https://codereview.chromium.org/2617393002/diff/1/src/code-stub-assembler.cc#...
src/code-stub-assembler.cc:2348: if (mode == SMI_PARAMETERS) {
On 2017/01/09 14:53:10, Igor Sheludko wrote:
> Maybe it would be better to introduce WordOrSmiShr and use IntPtrOrSmiAdd
here.

Done.

[commit-bot: I haz the power, 2017-01-10 01:46:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 01:46:07]

Dry run: This issue passed the CQ dry run.

[danno, 2017-01-10 01:46:28]

The CQ bit was checked by danno@chromium.org

[danno, 2017-01-10 01:46:28]

The patchset sent to the CQ was uploaded after l-g-t-m from ishell@chromium.org
Link to the patchset: https://codereview.chromium.org/2617393002/#ps20001
(title: "Review feedback")

[commit-bot: I haz the power, 2017-01-10 01:46:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 01:48:11]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484012788322100,
"parent_rev": "5560bbb498252334595a39bb5f313ac8eb82cfe1", "commit_rev":
"8e19a2c4972bb7c3aae723c37999bedd3f8343dc"}

[commit-bot: I haz the power, 2017-01-10 01:48:15]

Description was changed from

==========
[stubs] Ensure generated CalculateNewElementsCapacity is identical to runtime
version

The original TF port didn't maintain the same semantics as the CS/runtime
implementation, and in fact introduced a bug that grew capacity too slowly on
32-bit platforms.

R=ishell@chromium.org
LOG=N
==========

to

==========
[stubs] Ensure generated CalculateNewElementsCapacity is identical to runtime
version

The original TF port didn't maintain the same semantics as the CS/runtime
implementation, and in fact introduced a bug that grew capacity too slowly on
32-bit platforms.

R=ishell@chromium.org
LOG=N

Review-Url: https://codereview.chromium.org/2617393002
Cr-Commit-Position: refs/heads/master@{#42155}
Committed:
https://chromium.googlesource.com/v8/v8/+/8e19a2c4972bb7c3aae723c37999bedd3f8...
==========

[commit-bot: I haz the power, 2017-01-10 01:48:16]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/8e19a2c4972bb7c3aae723c37999bedd3f8...