Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issue 2617363003: Use map to distinguish type feedback vectors. (Closed)

Created:
3 years, 11 months ago by Yang
Modified:
3 years, 11 months ago
Reviewers:
mvstanton, ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Use map to distinguish type feedback vectors. R=mvstanton@chromium.org, ulan@chromium.org BUG=v8:5808 Review-Url: https://codereview.chromium.org/2617363003 Cr-Commit-Position: refs/heads/master@{#42137} Committed: https://chromium.googlesource.com/v8/v8/+/e24f3f3bd55995fbb2609ddd74a6a79e96f7d943

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M src/heap/heap.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/heap/heap.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/objects-inl.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/type-feedback-vector.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/type-feedback-vector-inl.h View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 12 (7 generated)
Yang
3 years, 11 months ago (2017-01-09 09:30:50 UTC) #1
mvstanton
lgtm https://codereview.chromium.org/2617363003/diff/1/src/type-feedback-vector-inl.h File src/type-feedback-vector-inl.h (right): https://codereview.chromium.org/2617363003/diff/1/src/type-feedback-vector-inl.h#newcode30 src/type-feedback-vector-inl.h:30: DCHECK(obj->IsTypeFeedbackMetadata()); Good catch!
3 years, 11 months ago (2017-01-09 09:56:38 UTC) #4
ulan
lgtm
3 years, 11 months ago (2017-01-09 12:07:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2617363003/1
3 years, 11 months ago (2017-01-09 12:25:29 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-09 12:27:08 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/e24f3f3bd55995fbb2609ddd74a6a79e96f...

Powered by Google App Engine
This is Rietveld 408576698