Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 2617333002: Add Vary: Accept encoding header to DRP Brotli tests (Closed)

Created:
3 years, 11 months ago by tbansal1
Modified:
3 years, 11 months ago
Reviewers:
RyanSturm
CC:
chromium-reviews, tbansal+watch-data-reduction-proxy_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add Vary: Accept encoding header to DRP Brotli tests The additional header ensures that even if the proxy server adds Vary accept encoding header, the second request is still served by the cache. BUG=634061 Review-Url: https://codereview.chromium.org/2617333002 Cr-Commit-Position: refs/heads/master@{#442309} Committed: https://chromium.googlesource.com/chromium/src/+/ee71e66f483b63c57c67fe350722a049579bd2ec

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc View 4 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
tbansal1
ryansturm: ptal. Thanks.
3 years, 11 months ago (2017-01-09 17:42:40 UTC) #8
RyanSturm
lgtm
3 years, 11 months ago (2017-01-09 18:52:02 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2617333002/1
3 years, 11 months ago (2017-01-09 18:53:16 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-09 19:31:00 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ee71e66f483b63c57c67fe350722...

Powered by Google App Engine
This is Rietveld 408576698