third_party/WebKit/Source/devtools/front_end/sdk/NetworkLog.js - Issue 2617283003: [Devtools] Removed getters/setters for NetworkRequest requestId

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/NetworkLog.js

Issue 2617283003: [Devtools] Removed getters/setters for NetworkRequest requestId (Closed)

Patch Set: Merge branch 'TYPE_OBJECT_JS' into REMOVE_GETTERS_SETTERS_1 Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/devtools/front_end/sdk/NetworkLog.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/NetworkLog.js b/third_party/WebKit/Source/devtools/front_end/sdk/NetworkLog.js

index e162859868860c63d68faf3243166eef773f1e45..2f35fb65213c5fce3a6f81aac4f0b7cb0ec75c2a 100644

--- a/third_party/WebKit/Source/devtools/front_end/sdk/NetworkLog.js

+++ b/third_party/WebKit/Source/devtools/front_end/sdk/NetworkLog.js

@@ -126,7 +126,7 @@ SDK.NetworkLog = class extends SDK.SDKModel {

if (!this._currentPageLoad)

this._currentPageLoad = new SDK.PageLoad(request);

this._requests.push(request);

- this._requestForId[request.requestId] = request;

+ this._requestForId[request.requestId()] = request;

request.__page = this._currentPageLoad;

}

@@ -138,7 +138,7 @@ SDK.NetworkLog = class extends SDK.SDKModel {

_onRequestStarted(event) {

var request = /** @type {!SDK.NetworkRequest} */ (event.data);

this._requests.push(request);

- this._requestForId[request.requestId] = request;

+ this._requestForId[request.requestId()] = request;

request.__page = this._currentPageLoad;

}