Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Unified Diff: third_party/WebKit/LayoutTests/vr/requestPresent_resolve_repeatwithgesture.html

Issue 2617183002: Add more WebVR layout tests, adjust test format (Closed)
Patch Set: Add some missing catches for failed getVRDisplays Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/vr/requestPresent_resolve_repeatwithgesture.html
diff --git a/third_party/WebKit/LayoutTests/vr/requestPresent_resolve_repeatwithgesture.html b/third_party/WebKit/LayoutTests/vr/requestPresent_resolve_repeatwithgesture.html
new file mode 100644
index 0000000000000000000000000000000000000000..a1d2814497429a6bdfc8fd533a3893b4c186af7c
--- /dev/null
+++ b/third_party/WebKit/LayoutTests/vr/requestPresent_resolve_repeatwithgesture.html
@@ -0,0 +1,60 @@
+<!DOCTYPE html>
bajones 2017/01/06 20:20:25 Not sure this test is useful. We test elsewhere th
bsheedy 2017/01/06 22:14:19 This was to address a specific bug that popped up
+<!-- Specific regression test for crbug.com/654909 -->
+<script src="../resources/testharness.js"></script>
+<script src="../resources/testharnessreport.js"></script>
+<script src="../resources/mojo-helpers.js"></script>
+<script src="resources/fake-vr-displays.js"></script>
+<script src="resources/mock-vr-service.js"></script>
+<canvas id="webgl-canvas"></canvas>
+<script src="resources/presentation-setup.js"></script>
+<script>
+let fakeDisplays = fakeVRDisplays();
+
+vr_test( (t) => {
+ return navigator.getVRDisplays().then( (displays) => {
+ t.step( () => {
+ assert_true(displays != null);
+ assert_equals(1, displays.length);
+ }, "getVRDisplays returned correct results");
+ var display = displays[0];
+
+ runWithUserGesture( () => {
+ display.requestPresent([{ source : webglCanvas }]).then( () => {
+ t.step( () => {
+ assert_true(display.isPresenting);
+ }, "Display should be presenting");
+
+ // Call requestPresent again after a short delay
+ setTimeout( () => {
+ runWithUserGesture( () => {
+ display.requestPresent([{ source : webglCanvas }]).then( () => {
+ t.step( () => {
+ assert_true(display.isPresenting);
+ }, "Display should still be presenting");
+ }, (err) => {
+ t.step( () => {
+ assert_unreached(err);
+ }, "Should never reach here");
+ }).then( () => {
+ t.done();
+ });
+ });
+ }, 100);
+
+ }, (err) => {
+ t.step( () => {
+ assert_unreached(err);
+ }, "Should never reach here");
+ t.done();
+ });
+ });
+ }, (err) => {
+ t.step( () => {
+ assert_unreached(err);
+ }, "getVRDisplays rejected");
+ t.done();
+ });
+}, [fakeDisplays["Pixel"]],
+"Test requestPresent resolves with a user gesture when already presenting");
+
+</script>

Powered by Google App Engine
This is Rietveld 408576698