third_party/WebKit/LayoutTests/vr/requestPresent_resolve_repeatwithgesture.html - Issue 2617183002: Add more WebVR layout tests, adjust test format

Side by Side Diff: third_party/WebKit/LayoutTests/vr/requestPresent_resolve_repeatwithgesture.html

Issue 2617183002: Add more WebVR layout tests, adjust test format (Closed)

Patch Set: Add some missing catches for failed getVRDisplays Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« third_party/WebKit/LayoutTests/vr/getVRDisplays_one_display.html ('K') | « third_party/WebKit/LayoutTests/vr/requestPresent_resolve.html ('k') | third_party/WebKit/LayoutTests/vr/requestPresent_resolve_repeatwithoutgesture.html » ('j') | third_party/WebKit/LayoutTests/vr/resources/fake-vr-displays.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>
	bajones 2017/01/06 20:20:25 Not sure this test is useful. We test elsewhere th Not sure this test is useful. We test elsewhere that requestPresent can run within a gesture, and then we test to make sure the edge case (repeated calls without a gesture) also works. As such this doesn't feel like it add any new coverage. bsheedy 2017/01/06 22:14:19 This was to address a specific bug that popped up Show quoted text On 2017/01/06 20:20:25, bajones wrote: > Not sure this test is useful. We test elsewhere that requestPresent can run > within a gesture, and then we test to make sure the edge case (repeated calls > without a gesture) also works. As such this doesn't feel like it add any new > coverage. This was to address a specific bug that popped up a while back. If you called requestPresent with a gesture, then called requestPresent again without a user gesture, rendering got messed up (https://bugs.chromium.org/p/chromium/issues/detail?id=654907). If you called requestPresent twice with a gesture, then the browser crashed (https://bugs.chromium.org/p/chromium/issues/detail?id=654909).
	2 <!-- Specific regression test for crbug.com/654909 -->

	3 <script src="../resources/testharness.js"></script>

	4 <script src="../resources/testharnessreport.js"></script>

	5 <script src="../resources/mojo-helpers.js"></script>

	6 <script src="resources/fake-vr-displays.js"></script>

	7 <script src="resources/mock-vr-service.js"></script>

	8 <canvas id="webgl-canvas"></canvas>

	9 <script src="resources/presentation-setup.js"></script>

	10 <script>

	11 let fakeDisplays = fakeVRDisplays();

	12

	13 vr_test( (t) => {

	14 return navigator.getVRDisplays().then( (displays) => {

	15 t.step( () => {

	16 assert_true(displays != null);

	17 assert_equals(1, displays.length);

	18 }, "getVRDisplays returned correct results");

	19 var display = displays[0];

	20

	21 runWithUserGesture( () => {

	22 display.requestPresent([{ source : webglCanvas }]).then( () => {

	23 t.step( () => {

	24 assert_true(display.isPresenting);

	25 }, "Display should be presenting");

	26

	27 // Call requestPresent again after a short delay

	28 setTimeout( () => {

	29 runWithUserGesture( () => {

	30 display.requestPresent([{ source : webglCanvas }]).then( () => {

	31 t.step( () => {

	32 assert_true(display.isPresenting);

	33 }, "Display should still be presenting");

	34 }, (err) => {

	35 t.step( () => {

	36 assert_unreached(err);

	37 }, "Should never reach here");

	38 }).then( () => {

	39 t.done();

	40 });

	41 });

	42 }, 100);

	43

	44 }, (err) => {

	45 t.step( () => {

	46 assert_unreached(err);

	47 }, "Should never reach here");

	48 t.done();

	49 });

	50 });

	51 }, (err) => {

	52 t.step( () => {

	53 assert_unreached(err);

	54 }, "getVRDisplays rejected");

	55 t.done();

	56 });

	57 }, [fakeDisplays["Pixel"]],

	58 "Test requestPresent resolves with a user gesture when already presenting");

	59

	60 </script>

OLD	NEW