Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 2617173002: Add a Javascript closure compiler target for VrShell. (Closed)

Created:
3 years, 11 months ago by cjgrant
Modified:
3 years, 11 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, vitalyp+closure_chromium.org, jlklein+watch-closure_chromium.org, dbeam+watch-closure_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a Javascript closure compiler target for VrShell. BUG= TEST=Ran third_party/closure_compiler/run_compiler vr_shell_ui Review-Url: https://codereview.chromium.org/2617173002 Cr-Commit-Position: refs/heads/master@{#442001} Committed: https://chromium.googlesource.com/chromium/src/+/5a0f9b4406b3b35ed71c96933e78f335b947d8ed

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M third_party/closure_compiler/compiled_resources2.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
cjgrant
3 years, 11 months ago (2017-01-06 18:16:03 UTC) #2
Dan Beam
lgtm
3 years, 11 months ago (2017-01-06 18:49:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2617173002/1
3 years, 11 months ago (2017-01-06 18:58:48 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-06 19:14:11 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5a0f9b4406b3b35ed71c96933e78...

Powered by Google App Engine
This is Rietveld 408576698