Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2617153002: Bug Fix: Crash When Getting Window Icon (Closed)

Created:
3 years, 11 months ago by qiangchen
Modified:
3 years, 11 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org, mcasas+watch+vc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Bug Fix: Crash When Getting Window Icon Crash is reported when doing screen share on hangouts. We found it initiates at a place where we try to get image for a null icon handle. This CL fixes the issue. BUG=676758 TEST=running screen share on hangouts Review-Url: https://codereview.chromium.org/2617153002 Cr-Commit-Position: refs/heads/master@{#442015} Committed: https://chromium.googlesource.com/chromium/src/+/a37268b72ce9073ad0dd298c3576ca1a66832688

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/browser/media/webrtc/window_icon_util_win.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
qiangchen
Can you take a look at this quick fix CL?
3 years, 11 months ago (2017-01-06 18:14:57 UTC) #3
DaleCurtis
lgtm
3 years, 11 months ago (2017-01-06 18:36:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2617153002/1
3 years, 11 months ago (2017-01-06 18:48:50 UTC) #6
commit-bot: I haz the power
3 years, 11 months ago (2017-01-06 19:55:25 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a37268b72ce9073ad0dd298c3576...

Powered by Google App Engine
This is Rietveld 408576698