WebmMuxer: do not set DefaultDuration if timestamp delta is not near constant

WebmMuxer: do not set DefaultDuration if timestamp delta is not near constant

WebmMuxer sets WebM's DefaultDuration to the expected delta between
frames (derived from the frame rate), but that messes up (some) players
due to frames arriving at a different rate. This is a legimimate case
if, e.g.  the encoded data stream is paused.

This CL essentially avoids setting this parameter so that players
can just look at each encoded frame timestamp instead.

[1] http://www.webmproject.org/docs/container/#track

BUG=606000
Review-Url: https://codereview.chromium.org/2617143003
Cr-Commit-Position: refs/heads/master@{#442081}
Committed: https://chromium.googlesource.com/chromium/src/+/50252de90c71b7d5d12c30121a82d4e790f74252

[mcasas, 2017-01-06 18:35:07]

Description was changed from

==========
'# Enter a description of the change.
WebmMuxer: do not set DefaultDuration if timestamp delta is not near constant

WebmMuxer sets WebM's DefaultDuration to the expected delta between
frames (derived from the frame rate), but that messes up (some) players
due to frames arriving at a different rate. This is a legimimate case
if, e.g.  the encoded data stream is paused.

This CL essentially avoids setting this parameter so that players
can just look at each encoded frame timestamp instead.

(Assuming [2] is referring to the correct DefaultDuration).


[1] http://www.webmproject.org/docs/container/#track
[2] https://bugs.chromium.org/p/chromium/issues/detail?id=606000#c32

BUG=606000
==========

to

==========
'# Enter a description of the change.
WebmMuxer: do not set DefaultDuration if timestamp delta is not near constant

WebmMuxer sets WebM's DefaultDuration to the expected delta between
frames (derived from the frame rate), but that messes up (some) players
due to frames arriving at a different rate. This is a legimimate case
if, e.g.  the encoded data stream is paused.

This CL essentially avoids setting this parameter so that players
can just look at each encoded frame timestamp instead.

[1] http://www.webmproject.org/docs/container/#track

BUG=606000
==========

[mcasas, 2017-01-06 18:35:28]

mcasas@chromium.org changed reviewers:
+ chcunningham@chromium.org

[mcasas, 2017-01-06 18:35:29]

chcunningham@ PTAL

(Assuming [2] is referring to the correct DefaultDuration).

[2] https://bugs.chromium.org/p/chromium/issues/detail?id=606000#c32

[chcunningham, 2017-01-06 19:05:34]

You've got a typo in the description
> '# Enter a description of the change.

LGTM

[mcasas, 2017-01-06 19:08:53]

Description was changed from

==========
'# Enter a description of the change.
WebmMuxer: do not set DefaultDuration if timestamp delta is not near constant

WebmMuxer sets WebM's DefaultDuration to the expected delta between
frames (derived from the frame rate), but that messes up (some) players
due to frames arriving at a different rate. This is a legimimate case
if, e.g.  the encoded data stream is paused.

This CL essentially avoids setting this parameter so that players
can just look at each encoded frame timestamp instead.

[1] http://www.webmproject.org/docs/container/#track

BUG=606000
==========

to

==========
WebmMuxer: do not set DefaultDuration if timestamp delta is not near constant

WebmMuxer sets WebM's DefaultDuration to the expected delta between
frames (derived from the frame rate), but that messes up (some) players
due to frames arriving at a different rate. This is a legimimate case
if, e.g.  the encoded data stream is paused.

This CL essentially avoids setting this parameter so that players
can just look at each encoded frame timestamp instead.

[1] http://www.webmproject.org/docs/container/#track

BUG=606000
==========

[mcasas, 2017-01-06 19:09:04]

On 2017/01/06 19:05:34, chcunningham wrote:
> You've got a typo in the description
> > '# Enter a description of the change.
> 
> LGTM

Ooops, corrected, thanks!

[mcasas, 2017-01-06 19:19:56]

The CQ bit was checked by mcasas@chromium.org

[commit-bot: I haz the power, 2017-01-06 19:20:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 22:46:42]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1483730396040610, "parent_rev":
"444e0bbea061042b4133f3bfea0c8d0a6db73aff", "commit_rev":
"50252de90c71b7d5d12c30121a82d4e790f74252"}

[commit-bot: I haz the power, 2017-01-06 22:47:10]

Description was changed from

==========
WebmMuxer: do not set DefaultDuration if timestamp delta is not near constant

WebmMuxer sets WebM's DefaultDuration to the expected delta between
frames (derived from the frame rate), but that messes up (some) players
due to frames arriving at a different rate. This is a legimimate case
if, e.g.  the encoded data stream is paused.

This CL essentially avoids setting this parameter so that players
can just look at each encoded frame timestamp instead.

[1] http://www.webmproject.org/docs/container/#track

BUG=606000
==========

to

==========
WebmMuxer: do not set DefaultDuration if timestamp delta is not near constant

WebmMuxer sets WebM's DefaultDuration to the expected delta between
frames (derived from the frame rate), but that messes up (some) players
due to frames arriving at a different rate. This is a legimimate case
if, e.g.  the encoded data stream is paused.

This CL essentially avoids setting this parameter so that players
can just look at each encoded frame timestamp instead.

[1] http://www.webmproject.org/docs/container/#track

BUG=606000

Review-Url: https://codereview.chromium.org/2617143003
Cr-Commit-Position: refs/heads/master@{#442081}
Committed:
https://chromium.googlesource.com/chromium/src/+/50252de90c71b7d5d12c30121a82...
==========

[commit-bot: I haz the power, 2017-01-06 22:47:11]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/50252de90c71b7d5d12c30121a82...