Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Unified Diff: third_party/WebKit/Source/core/page/PagePopupSupplement.h

Issue 2617113003: Use a new Supplement construtor in PagePopupController (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/page/PagePopupSupplement.h
diff --git a/third_party/WebKit/Source/core/page/PagePopupSupplement.h b/third_party/WebKit/Source/core/page/PagePopupSupplement.h
index 15cb0b41b66948f5c0baaf78f485054cdb5a42d7..ca37ecea8ee3d161c4c975375cff85f6a7feeee5 100644
--- a/third_party/WebKit/Source/core/page/PagePopupSupplement.h
+++ b/third_party/WebKit/Source/core/page/PagePopupSupplement.h
@@ -48,13 +48,16 @@ class CORE_EXPORT PagePopupSupplement final
USING_GARBAGE_COLLECTED_MIXIN(PagePopupSupplement);
public:
- static PagePopupController* pagePopupController(LocalFrame&);
+ static PagePopupSupplement& from(LocalFrame&);
static void install(LocalFrame&, PagePopup&, PagePopupClient*);
static void uninstall(LocalFrame&);
+
+ void dispose();
sof 2017/01/06 12:09:11 nit: make dispose() private?
+ PagePopupController* pagePopupController() const;
DECLARE_TRACE();
private:
- PagePopupSupplement(PagePopup&, PagePopupClient*);
+ PagePopupSupplement(LocalFrame&, PagePopup&, PagePopupClient*);
static const char* supplementName();
Member<PagePopupController> m_controller;

Powered by Google App Engine
This is Rietveld 408576698