Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2617113002: Handle repeated and overlapping (re)starts of mock speechrecognizer. (Closed)

Created:
3 years, 11 months ago by sof
Modified:
3 years, 11 months ago
CC:
chromium-reviews, blink-reviews, einbinder+watch-test-runner_chromium.org, mlamouri+watch-test-runner_chromium.org, jochen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Handle repeated and overlapping (re)starts of mock speechrecognizer. R=tommi BUG=678863 Review-Url: https://codereview.chromium.org/2617113002 Cr-Commit-Position: refs/heads/master@{#442337} Committed: https://chromium.googlesource.com/chromium/src/+/79aa660163717efbbcea224cb855ac258216ada8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -1 line) Patch
M components/test_runner/mock_web_speech_recognizer.h View 1 chunk +2 lines, -0 lines 0 comments Download
M components/test_runner/mock_web_speech_recognizer.cc View 2 chunks +9 lines, -1 line 0 comments Download
A third_party/WebKit/LayoutTests/fast/speech/scripted/speechrecognition-re-restart.html View 1 chunk +30 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/speech/scripted/speechrecognition-re-restart-expected.txt View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (11 generated)
sof
please take a look. (for reasons unknown, these speech-related fuzzer crashes end up in my ...
3 years, 11 months ago (2017-01-06 10:27:35 UTC) #4
tommi (sloooow) - chröme
lgtm
3 years, 11 months ago (2017-01-06 11:14:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2617113002/1
3 years, 11 months ago (2017-01-06 11:49:34 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/336348)
3 years, 11 months ago (2017-01-06 11:55:05 UTC) #12
sof
thanks; dmazzoni@: test_runner/ owner approval? tia
3 years, 11 months ago (2017-01-06 12:01:26 UTC) #13
dmazzoni
lgtm
3 years, 11 months ago (2017-01-09 19:17:49 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2617113002/1
3 years, 11 months ago (2017-01-09 19:18:45 UTC) #16
commit-bot: I haz the power
3 years, 11 months ago (2017-01-09 20:51:44 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/79aa660163717efbbcea224cb855...

Powered by Google App Engine
This is Rietveld 408576698