Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 2617043003: Move TouchTransformerController to ui/display/. (Closed)

Created:
3 years, 11 months ago by kylechar
Modified:
3 years, 11 months ago
Reviewers:
oshima, reed1
CC:
chromium-reviews, rjkroege, kalyank, sadrul, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move TouchTransformerController to ui/display/. We need to add touchscreen support to mustash where display and input-device management happens in a different process from ash. Decouple ash::TouchTransformerController from the rest of ash and move to src/ui/display/ so it can be used with mus. This also decouples and moves the accompanying tests. The dependency on WindowTreeHostManager can't be broken so add AshTouchTransformController which extends TouchTransformController and listens for ash display configuration changes. BUG=679747 Review-Url: https://codereview.chromium.org/2617043003 Cr-Commit-Position: refs/heads/master@{#443037} Committed: https://chromium.googlesource.com/chromium/src/+/55f0eaf2e3f710faafcae8cf32546729adce93b6

Patch Set 1 #

Patch Set 2 : Rebase / cleanup. #

Patch Set 3 : Rebase / split CL. #

Patch Set 4 : Add comments. #

Total comments: 2

Patch Set 5 : Make DEPS for one file. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+351 lines, -1480 lines) Patch
M ash/BUILD.gn View 1 2 2 chunks +2 lines, -3 lines 0 comments Download
M ash/shell.h View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M ash/shell.cc View 1 2 2 chunks +5 lines, -4 lines 0 comments Download
A ash/touch/ash_touch_transform_controller.h View 1 1 chunk +41 lines, -0 lines 0 comments Download
A ash/touch/ash_touch_transform_controller.cc View 1 1 chunk +31 lines, -0 lines 0 comments Download
D ash/touch/touch_transformer_controller.h View 1 chunk +0 lines, -84 lines 0 comments Download
D ash/touch/touch_transformer_controller.cc View 1 chunk +0 lines, -386 lines 0 comments Download
D ash/touch/touch_transformer_controller_unittest.cc View 1 chunk +0 lines, -828 lines 0 comments Download
M chrome/browser/chromeos/display/touch_calibrator/touch_calibrator_controller.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M ui/display/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ui/display/manager/BUILD.gn View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A ui/display/manager/chromeos/DEPS View 1 2 3 4 1 chunk +5 lines, -0 lines 0 comments Download
A ui/display/manager/chromeos/touch_transform_controller.h View 1 2 3 4 1 chunk +90 lines, -0 lines 0 comments Download
A + ui/display/manager/chromeos/touch_transform_controller.cc View 1 2 10 chunks +59 lines, -78 lines 0 comments Download
A + ui/display/manager/chromeos/touch_transform_controller_unittest.cc View 1 24 chunks +110 lines, -91 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 23 (17 generated)
kylechar
3 years, 11 months ago (2017-01-10 16:51:46 UTC) #5
oshima
lgtm with one nit https://codereview.chromium.org/2617043003/diff/100001/ui/display/manager/DEPS File ui/display/manager/DEPS (right): https://codereview.chromium.org/2617043003/diff/100001/ui/display/manager/DEPS#newcode3 ui/display/manager/DEPS:3: "+third_party/skia", can you add this ...
3 years, 11 months ago (2017-01-10 17:02:26 UTC) #6
kylechar
Thanks oshima! +reed for DEPS third_party/skia addition. https://codereview.chromium.org/2617043003/diff/100001/ui/display/manager/DEPS File ui/display/manager/DEPS (right): https://codereview.chromium.org/2617043003/diff/100001/ui/display/manager/DEPS#newcode3 ui/display/manager/DEPS:3: "+third_party/skia", On ...
3 years, 11 months ago (2017-01-10 18:18:37 UTC) #8
reed1
lgtm
3 years, 11 months ago (2017-01-11 21:13:32 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2617043003/120001
3 years, 11 months ago (2017-01-11 21:56:38 UTC) #20
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 22:58:12 UTC) #23
Message was sent while issue was closed.
Committed patchset #5 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/55f0eaf2e3f710faafcae8cf3254...

Powered by Google App Engine
This is Rietveld 408576698