Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1885)

Issue 2617043002: DevTools: Cookies panel toolbar changes (Closed)

Created:
3 years, 11 months ago by phulce
Modified:
3 years, 11 months ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Cookies panel toolbar changes Paving the way to expose all relevant cookies per 673934. * Adds filter bar with text match on name, value, and domain * Converts invisible state buttons into disabled states BUG=673934 Review-Url: https://codereview.chromium.org/2617043002 Cr-Commit-Position: refs/heads/master@{#441996} Committed: https://chromium.googlesource.com/chromium/src/+/e344cf0c658526a278eeae8817026b1a032b5633

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -14 lines) Patch
M third_party/WebKit/Source/devtools/front_end/resources/CookieItemsView.js View 6 chunks +49 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/resources/resourcesPanel.css View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
phulce
3 years, 11 months ago (2017-01-05 22:32:33 UTC) #4
pfeldman
lgtm
3 years, 11 months ago (2017-01-06 06:54:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2617043002/1
3 years, 11 months ago (2017-01-06 17:24:55 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-06 18:57:04 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e344cf0c658526a278eeae881702...

Powered by Google App Engine
This is Rietveld 408576698