Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Issue 2617023003: Fix PreRunValidation calls in two of UIThreadExtensionFunction's subclasses. (Closed)

Created:
3 years, 11 months ago by lazyboy
Modified:
3 years, 11 months ago
Reviewers:
Devlin
CC:
chromium-reviews, extensions-reviews_chromium.org, yamaguchi+watch_chromium.org, oka+watch_chromium.org, oshima+watch_chromium.org, fukino+watch_chromium.org, chromium-apps-reviews_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix PreRunValidation calls in two of UIThreadExtensionFunction's subclasses. From what I can tell, skipping base (UITEF) class's PreRunValidation isn't a good idea. Make those subclasses include calling the base function. The two subclasses are: AppCurrentWindowInternalExtensionFunction and FileSystemProviderInternalFunction BUG=None Test=None, in theory we should correctly send errors to extension APIs when browser is shutting down. Review-Url: https://codereview.chromium.org/2617023003 Cr-Commit-Position: refs/heads/master@{#441839} Committed: https://chromium.googlesource.com/chromium/src/+/83e30d0ef0da7e8559ffec15b1228735b9d816df

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/browser/chromeos/extensions/file_system_provider/provider_function.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M extensions/browser/api/app_current_window_internal/app_current_window_internal_api.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
lazyboy
3 years, 11 months ago (2017-01-05 22:21:01 UTC) #2
Devlin
lgtm. When is there going to be a C++ feature for ensuring super class's methods ...
3 years, 11 months ago (2017-01-05 23:34:01 UTC) #3
lazyboy
:)
3 years, 11 months ago (2017-01-05 23:52:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2617023003/1
3 years, 11 months ago (2017-01-05 23:52:40 UTC) #6
commit-bot: I haz the power
3 years, 11 months ago (2017-01-06 02:38:33 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/83e30d0ef0da7e8559ffec15b122...

Powered by Google App Engine
This is Rietveld 408576698