Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(609)

Issue 2617013003: Don't hardcode 'dart' as the executable name to spawn. (Closed)

Created:
3 years, 11 months ago by Bob Nystrom
Modified:
3 years, 11 months ago
Reviewers:
vsm
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Don't hardcode 'dart' as the executable name to spawn. I don't think it's on the PATH on the buildbots. R=vsm@google.com Committed: https://github.com/dart-lang/sdk/commit/d1030e9be0a706b90042f0e05bb79ae38bc3b006

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M pkg/dev_compiler/test/worker/worker_test.dart View 12 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Bob Nystrom
3 years, 11 months ago (2017-01-06 00:32:07 UTC) #2
vsm
lgtm
3 years, 11 months ago (2017-01-06 00:43:04 UTC) #3
Bob Nystrom
3 years, 11 months ago (2017-01-06 00:44:12 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d1030e9be0a706b90042f0e05bb79ae38bc3b006 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698