Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Unified Diff: pkg/dev_compiler/test/worker/worker_test.dart

Issue 2617013003: Don't hardcode 'dart' as the executable name to spawn. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/dev_compiler/test/worker/worker_test.dart
diff --git a/pkg/dev_compiler/test/worker/worker_test.dart b/pkg/dev_compiler/test/worker/worker_test.dart
index af70a38e20bf016804779bdca6f8e8d491f8baa8..7f2aa11686a530a9bb6bb6966c8288d6b406ade7 100644
--- a/pkg/dev_compiler/test/worker/worker_test.dart
+++ b/pkg/dev_compiler/test/worker/worker_test.dart
@@ -44,7 +44,7 @@ main() {
test('can compile in worker mode', () async {
var args = executableArgs.toList()..add('--persistent_worker');
- var process = await Process.start('dart', args);
+ var process = await Process.start(Platform.executable, args);
var messageGrouper = new AsyncMessageGrouper(process.stdout);
var request = new WorkRequest();
@@ -76,7 +76,7 @@ main() {
test('can compile in basic mode', () {
var args = executableArgs.toList()..addAll(compilerArgs);
- var result = Process.runSync('dart', args);
+ var result = Process.runSync(Platform.executable, args);
expect(result.exitCode, EXIT_CODE_OK);
expect(result.stdout, isEmpty);
@@ -88,7 +88,7 @@ main() {
var args = new List<String>.from(executableArgs)
..add('--does-not-exist')
..addAll(compilerArgs);
- var result = Process.runSync('dart', args);
+ var result = Process.runSync(Platform.executable, args);
expect(result.exitCode, 64);
expect(result.stdout,
@@ -102,7 +102,7 @@ main() {
..add('--does-not-exist')
..add('--ignore-unrecognized-flags')
..addAll(compilerArgs);
- var result = Process.runSync('dart', args);
+ var result = Process.runSync(Platform.executable, args);
expect(result.exitCode, EXIT_CODE_OK);
expect(result.stdout, isEmpty);
@@ -114,7 +114,7 @@ main() {
argsFile.createSync();
argsFile.writeAsStringSync(compilerArgs.join('\n'));
var args = executableArgs.toList()..add('@${argsFile.path}');
- var process = await Process.start('dart', args);
+ var process = await Process.start(Platform.executable, args);
stderr.addStream(process.stderr);
var futureProcessOutput = process.stdout.map(UTF8.decode).toList();
@@ -148,7 +148,7 @@ main() {
test('can compile in basic mode', () {
final dartSdkSummary = new File('lib/sdk/ddc_sdk.sum').absolute;
- var result = Process.runSync('dart', [
+ var result = Process.runSync(Platform.executable, [
'bin/dartdevc.dart',
'--summary-extension=api.ds',
'--no-source-map',
@@ -164,7 +164,7 @@ main() {
expect(greetingJS.existsSync(), isTrue);
expect(greetingSummary.existsSync(), isTrue);
- result = Process.runSync('dart', [
+ result = Process.runSync(Platform.executable, [
'bin/dartdevc.dart',
'--no-source-map',
'--no-summarize',
@@ -195,7 +195,7 @@ main() {
});
test('incorrect usage', () {
- var result = Process.runSync('dart', [
+ var result = Process.runSync(Platform.executable, [
'bin/dartdevc.dart',
'--dart-sdk-summary',
dartSdkSummary.path,
@@ -209,7 +209,7 @@ main() {
test('compile errors', () {
badFileDart.writeAsStringSync('main() => "hello world"');
- var result = Process.runSync('dart', [
+ var result = Process.runSync(Platform.executable, [
'bin/dartdevc.dart',
'--no-source-map',
'--dart-sdk-summary',
@@ -245,7 +245,7 @@ main() {
});
test('works if part and library supplied', () {
- var result = Process.runSync('dart', [
+ var result = Process.runSync(Platform.executable, [
'bin/dartdevc.dart',
'--no-summarize',
'--no-source-map',
@@ -263,7 +263,7 @@ main() {
});
test('works if part is not supplied', () {
- var result = Process.runSync('dart', [
+ var result = Process.runSync(Platform.executable, [
'bin/dartdevc.dart',
'--no-summarize',
'--no-source-map',
@@ -280,7 +280,7 @@ main() {
});
test('part without library is silently ignored', () {
- var result = Process.runSync('dart', [
+ var result = Process.runSync(Platform.executable, [
'bin/dartdevc.dart',
'--no-summarize',
'--no-source-map',
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698