Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 2616963002: Remove unused Canvas::DrawStringRectWithShadows(). (Closed)

Created:
3 years, 11 months ago by Evan Stade
Modified:
3 years, 11 months ago
Reviewers:
sky
CC:
chromium-reviews, Ian Vollick, jbauman+watch_chromium.org, piman+watch_chromium.org, kalyank, danakj+watch_chromium.org, cc-bugs_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused Canvas::DrawStringRectWithShadows(). BUG=624175 Review-Url: https://codereview.chromium.org/2616963002 Cr-Commit-Position: refs/heads/master@{#441760} Committed: https://chromium.googlesource.com/chromium/src/+/c6686c5bc30f863b9ec341f761708c767ab1673c

Patch Set 1 #

Patch Set 2 : missing fwd decl #

Patch Set 3 : iwyu #

Patch Set 4 : more iwyu #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -88 lines) Patch
M ash/magnifier/partial_magnification_controller.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/download/download_item_cell.mm View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M ui/compositor/layer_unittest.cc View 3 chunks +0 lines, -44 lines 0 comments Download
M ui/gfx/canvas.h View 1 3 chunks +1 line, -12 lines 0 comments Download
M ui/gfx/canvas.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M ui/gfx/canvas_notimplemented.cc View 1 chunk +5 lines, -7 lines 0 comments Download
M ui/gfx/canvas_skia.cc View 2 chunks +7 lines, -16 lines 0 comments Download
D ui/gfx/test/data/compositor/string_with_shadows.png View Binary file 0 comments Download
M ui/views/bubble/bubble_border.cc View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M ui/views/controls/button/toggle_button.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 20 (16 generated)
Evan Stade
3 years, 11 months ago (2017-01-05 19:09:47 UTC) #12
sky
LGTM
3 years, 11 months ago (2017-01-05 20:15:16 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2616963002/60001
3 years, 11 months ago (2017-01-05 21:25:42 UTC) #17
commit-bot: I haz the power
3 years, 11 months ago (2017-01-05 21:31:53 UTC) #20
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/c6686c5bc30f863b9ec341f76170...

Powered by Google App Engine
This is Rietveld 408576698