Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2616953002: RecentTabsPage code cleanup. (Closed)

Created:
3 years, 11 months ago by Michael van Ouwerkerk
Modified:
3 years, 11 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, noyau+watch_chromium.org, ntp-dev+reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

RecentTabsPage code cleanup. * Delete some one-line helper functions. * Provide some more default method implementations in class Group. BUG=659631 Review-Url: https://codereview.chromium.org/2616953002 Cr-Commit-Position: refs/heads/master@{#441946} Committed: https://chromium.googlesource.com/chromium/src/+/8739cd56aa328f7972c60cba5f0d3348a108c273

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -43 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsPage.java View 2 chunks +1 line, -6 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsRowAdapter.java View 10 chunks +9 lines, -37 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
Michael van Ouwerkerk
Bernhard, could you take a look please?
3 years, 11 months ago (2017-01-05 15:57:24 UTC) #4
Bernhard Bauer
lgtm
3 years, 11 months ago (2017-01-05 18:51:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2616953002/20001
3 years, 11 months ago (2017-01-06 15:35:34 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-06 16:17:10 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8739cd56aa328f7972c60cba5f0d...

Powered by Google App Engine
This is Rietveld 408576698