Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 2616943002: [Signin iOS] Update order of buttons in dialog for merging data (Closed)

Created:
3 years, 11 months ago by bzanotti
Modified:
3 years, 11 months ago
Reviewers:
lpromero
CC:
chromium-reviews, tfarina, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Signin iOS] Update order of buttons in dialog for merging data The first one should always be the default one. Updated switch case: http://screen/Fy4RTuNHCYE.png Updated sign-in case: http://screen/PNCAG7SgMKs.png BUG=660418 Review-Url: https://codereview.chromium.org/2616943002 Cr-Commit-Position: refs/heads/master@{#441810} Committed: https://chromium.googlesource.com/chromium/src/+/9f12c413bd54610816c90bc31a7768113463f55b

Patch Set 1 #

Patch Set 2 : Fix unit tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -15 lines) Patch
M ios/chrome/app/strings/ios_strings.grd View 1 chunk +0 lines, -3 lines 0 comments Download
M ios/chrome/browser/ui/settings/import_data_collection_view_controller.mm View 2 chunks +11 lines, -5 lines 0 comments Download
M ios/chrome/browser/ui/settings/import_data_collection_view_controller_unittest.mm View 1 1 chunk +7 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
bzanotti
Please take a look.
3 years, 11 months ago (2017-01-05 15:55:35 UTC) #2
lpromero
lgtm
3 years, 11 months ago (2017-01-05 23:02:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2616943002/20001
3 years, 11 months ago (2017-01-05 23:03:02 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-06 01:55:31 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9f12c413bd54610816c90bc31a77...

Powered by Google App Engine
This is Rietveld 408576698