Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 2616923002: Replace [CallWith=ExecutionContext] with [CallWith=ScriptState] (Closed)

Created:
3 years, 11 months ago by riju_
Modified:
3 years, 11 months ago
Reviewers:
haraken
CC:
chromium-reviews, shans, rjwright, blink-reviews-style_chromium.org, tzik, blink-reviews-animation_chromium.org, blink-reviews-css, sof, eae+blinkwatch, dcheng, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews-html_chromium.org, apavlov+blink_chromium.org, nhiroki, darktears, blink-reviews, rwlbuis, kinuko+fileapi, Eric Willigers
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace [CallWith=ExecutionContext] with [CallWith=ScriptState] Replace [CallWith=ExecutionContext] with [CallWith=ScriptState] in Source/core/ BUG=670618 Review-Url: https://codereview.chromium.org/2616923002 Cr-Commit-Position: refs/heads/master@{#442253} Committed: https://chromium.googlesource.com/chromium/src/+/5c18ca83ce715937d62a4d5340398740535e8925

Patch Set 1 #

Patch Set 2 : Fix errors #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -73 lines) Patch
M third_party/WebKit/Source/core/animation/ElementAnimation.h View 4 chunks +10 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/animation/ElementAnimation.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/clipboard/DataTransferItem.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/clipboard/DataTransferItem.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/clipboard/DataTransferItem.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/DOMStringList.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DOMStringList.cpp View 3 chunks +9 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DOMStringList.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/fileapi/FileReaderSync.h View 2 chunks +7 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/fileapi/FileReaderSync.cpp View 4 chunks +13 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/fileapi/FileReaderSync.idl View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/frame/History.h View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/frame/History.cpp View 2 chunks +7 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/frame/History.idl View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/FormData.h View 3 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/FormData.cpp View 2 chunks +6 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/FormData.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/testing/DictionaryTest.h View 3 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/testing/DictionaryTest.cpp View 2 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/testing/DictionaryTest.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/timing/SharedWorkerPerformance.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/timing/SharedWorkerPerformance.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/timing/SharedWorkerPerformance.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (12 generated)
riju_
PTAL.
3 years, 11 months ago (2017-01-09 14:20:40 UTC) #8
haraken
LGTM
3 years, 11 months ago (2017-01-09 14:22:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2616923002/20001
3 years, 11 months ago (2017-01-09 15:24:02 UTC) #13
commit-bot: I haz the power
3 years, 11 months ago (2017-01-09 15:28:29 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5c18ca83ce715937d62a4d534039...

Powered by Google App Engine
This is Rietveld 408576698