Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2616913002: eventTargetData(): pull (most of) this singleton off-heap. (Closed)

Created:
3 years, 11 months ago by sof
Modified:
3 years, 11 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

eventTargetData(): pull (most of) this singleton off-heap. Diagnose mutation of GCed object by pulling the collection wrapper off heap also. R= BUG=678532 Review-Url: https://codereview.chromium.org/2616913002 Cr-Commit-Position: refs/heads/master@{#441668} Committed: https://chromium.googlesource.com/chromium/src/+/d2b4f97c86fb46524c444730950c9b5f70cbf653

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/Source/core/dom/Node.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
sof
please take a look. increasing signs of one or more heap mutation issues in existence?
3 years, 11 months ago (2017-01-05 14:04:39 UTC) #4
haraken
LGTM
3 years, 11 months ago (2017-01-05 15:16:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2616913002/1
3 years, 11 months ago (2017-01-05 16:24:55 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-05 16:29:38 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d2b4f97c86fb46524c444730950c...

Powered by Google App Engine
This is Rietveld 408576698