Remove ScriptController::namedItemAdded/Removed

Remove ScriptController::namedItemAdded/Removed

They are unnecessary indirection to WindowProxy::namedItemAdded/Removed.

Also this CL updates a dcheck in WindowProxy::namedItemAdded/Removed to verify
that those methods are called after the window proxy is initialized.

(The check will be replaced with a better lifecycle model in a follow-up CL.)

BUG=677253
Review-Url: https://codereview.chromium.org/2616903002
Cr-Commit-Position: refs/heads/master@{#441803}
Committed: https://chromium.googlesource.com/chromium/src/+/5807dc6e5f6be9c395dc81b43335055f2d6a2a97

[haraken, 2017-01-05 13:20:10]

haraken@chromium.org changed reviewers:
+ yukishiino@chromium.org

[haraken, 2017-01-05 13:20:10]

PTAL

[Yuki, 2017-01-05 13:31:27]

LGTM.

https://codereview.chromium.org/2616903002/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp (right):

https://codereview.chromium.org/2616903002/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp:522: if
(!m_scriptState->contextIsValid())
Why do you want to replace !isContextInitialized() with
!m_scriptState->contextIsValid()?  They are almost the same except for the check
of m_scriptState.

We already have isContextInitialized() and isGlobalInitialized, and it's a kind
of headache.  I don't want to introduce yet another kind of check.

[haraken, 2017-01-05 23:50:26]

https://codereview.chromium.org/2616903002/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp (right):

https://codereview.chromium.org/2616903002/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp:522: if
(!m_scriptState->contextIsValid())
On 2017/01/05 13:31:27, Yuki wrote:
> Why do you want to replace !isContextInitialized() with
> !m_scriptState->contextIsValid()?  They are almost the same except for the
check
> of m_scriptState.
> 
> We already have isContextInitialized() and isGlobalInitialized, and it's a
kind
> of headache.  I don't want to introduce yet another kind of check.

Reverted it back to !isContextInitialized().

I just wanted to use the contextIsValid() check because:

  if (!m_scriptState->contextIsValid()) return;
  ScriptState::Scope scope(m_scriptState.get());

is an idiom.

However, in this specific case, !m_scriptState->contextIsValid() is equivalent
to !isContextInitialized(), as you mentioned.

[haraken, 2017-01-05 23:50:31]

The CQ bit was checked by haraken@chromium.org

[haraken, 2017-01-05 23:50:31]

The patchset sent to the CQ was uploaded after l-g-t-m from
yukishiino@chromium.org
Link to the patchset: https://codereview.chromium.org/2616903002/#ps20001
(title: "temp")

[commit-bot: I haz the power, 2017-01-05 23:51:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 01:46:13]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1483660231077450,
"parent_rev": "e46baf31c8607e58385f55a79b31e941d29e204f", "commit_rev":
"5807dc6e5f6be9c395dc81b43335055f2d6a2a97"}

[commit-bot: I haz the power, 2017-01-06 01:46:43]

Description was changed from

==========
Remove ScriptController::namedItemAdded/Removed

They are unnecessary indirection to WindowProxy::namedItemAdded/Removed.

Also this CL updates a dcheck in WindowProxy::namedItemAdded/Removed to verify
that those methods are called after the window proxy is initialized.

(The check will be replaced with a better lifecycle model in a follow-up CL.)

BUG=677253
==========

to

==========
Remove ScriptController::namedItemAdded/Removed

They are unnecessary indirection to WindowProxy::namedItemAdded/Removed.

Also this CL updates a dcheck in WindowProxy::namedItemAdded/Removed to verify
that those methods are called after the window proxy is initialized.

(The check will be replaced with a better lifecycle model in a follow-up CL.)

BUG=677253

Review-Url: https://codereview.chromium.org/2616903002
Cr-Commit-Position: refs/heads/master@{#441803}
Committed:
https://chromium.googlesource.com/chromium/src/+/5807dc6e5f6be9c395dc81b43335...
==========

[commit-bot: I haz the power, 2017-01-06 01:46:43]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5807dc6e5f6be9c395dc81b43335...