Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2616863002: Remove TransformOperation::None (Closed)

Created:
3 years, 11 months ago by Timothy Loh
Modified:
3 years, 11 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-css, chromium-reviews, dglazkov+blink, Eric Willigers, kinuko+watch, rjwright, rwlbuis, shans
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove TransformOperation::None This patch removes the enum value TransformOperation::None, which is currently only used in an ASSERT_NOT_REACHED case. Review-Url: https://codereview.chromium.org/2616863002 Cr-Commit-Position: refs/heads/master@{#443092} Committed: https://chromium.googlesource.com/chromium/src/+/54aed49c7088d08159b8ed7485a070160cd98d40

Patch Set 1 #

Total comments: 2

Patch Set 2 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -17 lines) Patch
M third_party/WebKit/Source/core/css/resolver/TransformBuilder.cpp View 1 2 chunks +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/animation/AnimationTranslationUtil.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/transforms/TransformOperation.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/transforms/TransformOperations.cpp View 1 2 chunks +2 lines, -10 lines 0 comments Download

Messages

Total messages: 19 (12 generated)
Timothy Loh
Miscellaneous clean-up :)
3 years, 11 months ago (2017-01-05 06:26:16 UTC) #4
alancutter (OOO until 2018)
lgtm https://codereview.chromium.org/2616863002/diff/1/third_party/WebKit/Source/core/css/resolver/TransformBuilder.cpp File third_party/WebKit/Source/core/css/resolver/TransformBuilder.cpp (right): https://codereview.chromium.org/2616863002/diff/1/third_party/WebKit/Source/core/css/resolver/TransformBuilder.cpp#newcode100 third_party/WebKit/Source/core/css/resolver/TransformBuilder.cpp:100: return TransformOperation::Scale; Optional nit: Consider putting the default ...
3 years, 11 months ago (2017-01-05 06:46:40 UTC) #6
Justin Novosad
lgtm https://codereview.chromium.org/2616863002/diff/1/third_party/WebKit/Source/platform/animation/AnimationTranslationUtil.cpp File third_party/WebKit/Source/platform/animation/AnimationTranslationUtil.cpp (left): https://codereview.chromium.org/2616863002/diff/1/third_party/WebKit/Source/platform/animation/AnimationTranslationUtil.cpp#oldcode123 third_party/WebKit/Source/platform/animation/AnimationTranslationUtil.cpp:123: case TransformOperation::None: Nit: perhaps a "default:" for this ...
3 years, 11 months ago (2017-01-10 16:40:03 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2616863002/20001
3 years, 11 months ago (2017-01-11 06:43:46 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/97842)
3 years, 11 months ago (2017-01-11 08:03:39 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2616863002/20001
3 years, 11 months ago (2017-01-12 00:13:35 UTC) #16
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 00:55:55 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/54aed49c7088d08159b8ed7485a0...

Powered by Google App Engine
This is Rietveld 408576698