Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2616843004: [ios] Removed deprecated methods from CRWWebUserInterfaceDelegate. (Closed)

Created:
3 years, 11 months ago by Eugene But (OOO till 7-30)
Modified:
3 years, 11 months ago
Reviewers:
michaeldo
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Removed deprecated methods from CRWWebUserInterfaceDelegate. These methods are not implemented by Tab anymore. BUG=661445 Review-Url: https://codereview.chromium.org/2616843004 Cr-Commit-Position: refs/heads/master@{#442013} Committed: https://chromium.googlesource.com/chromium/src/+/62430eb9fc26862ecc4f8b7adb8ad558f4dfc73f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -122 lines) Patch
M ios/web/public/web_state/crw_web_user_interface_delegate.h View 2 chunks +0 lines, -42 lines 0 comments Download
M ios/web/web_state/ui/crw_web_controller.mm View 4 chunks +32 lines, -80 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (8 generated)
Eugene But (OOO till 7-30)
3 years, 11 months ago (2017-01-06 00:30:26 UTC) #3
michaeldo
lgtm
3 years, 11 months ago (2017-01-06 18:26:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2616843004/1
3 years, 11 months ago (2017-01-06 19:42:08 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-06 19:46:33 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/62430eb9fc26862ecc4f8b7adb8a...

Powered by Google App Engine
This is Rietveld 408576698