Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 2616843002: Remove deprecated wait_util methods. (Closed)

Created:
3 years, 11 months ago by michaeldo
Modified:
3 years, 11 months ago
CC:
chromium-reviews, vmpstr+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove deprecated wait_util methods. BUG=521138 Review-Url: https://codereview.chromium.org/2616843002 Cr-Commit-Position: refs/heads/master@{#442940} Committed: https://chromium.googlesource.com/chromium/src/+/e5e7e6fb6650455ed305b5e2cfffe0c73cadbfc8

Patch Set 1 #

Patch Set 2 : Convert remaining uses of WaitUntilCondition. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -47 lines) Patch
M base/test/ios/wait_util.h View 2 chunks +0 lines, -16 lines 0 comments Download
M base/test/ios/wait_util.mm View 2 chunks +1 line, -15 lines 0 comments Download
M ios/chrome/browser/ui/contextual_search/touch_to_search_permissions_mediator_unittest.mm View 1 3 chunks +3 lines, -3 lines 0 comments Download
M ios/chrome/browser/ui/ntp/new_tab_page_perftest.mm View 1 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/omnibox_perftest.mm View 1 4 chunks +4 lines, -4 lines 0 comments Download
M ios/chrome/browser/ui/stack_view/stack_view_controller_perftest.mm View 1 4 chunks +5 lines, -5 lines 0 comments Download
M ios/web/public/test/web_test_with_web_state.mm View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
michaeldo
3 years, 11 months ago (2017-01-05 03:43:25 UTC) #1
michaeldo
3 years, 11 months ago (2017-01-10 16:56:46 UTC) #3
rohitrao (ping after 24h)
lgtm
3 years, 11 months ago (2017-01-10 17:23:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2616843002/1
3 years, 11 months ago (2017-01-10 22:05:03 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-clang/builds/18631) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 11 months ago (2017-01-10 22:12:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2616843002/20001
3 years, 11 months ago (2017-01-11 16:57:54 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 17:20:51 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e5e7e6fb6650455ed305b5e2cfff...

Powered by Google App Engine
This is Rietveld 408576698