Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 2616813002: Remove CFX_MapPtrToPtr from xfa/fde. (Closed)

Created:
3 years, 11 months ago by Tom Sepez
Modified:
3 years, 11 months ago
Reviewers:
Lei Zhang, dsinclair
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove CFX_MapPtrToPtr from xfa/fde. Fix spelling of "pseudo" along the way. Remove some FDE_LPCxxx typedefs for the sake of clarity. Review-Url: https://codereview.chromium.org/2616813002 Committed: https://pdfium.googlesource.com/pdfium/+/e4d611c9c6d882bd47b6936554bdfc5c1ea614a0

Patch Set 1 #

Total comments: 1

Patch Set 2 : no FDE_LPC* #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -104 lines) Patch
M xfa/fde/css/cfde_cssrulecollection.cpp View 5 chunks +28 lines, -27 lines 0 comments Download
M xfa/fde/css/fde_css.h View 1 chunk +6 lines, -5 lines 0 comments Download
M xfa/fde/css/fde_cssdatatable.h View 1 1 chunk +12 lines, -10 lines 0 comments Download
M xfa/fde/css/fde_cssdatatable.cpp View 1 6 chunks +12 lines, -11 lines 0 comments Download
M xfa/fde/css/fde_cssstyleselector.h View 5 chunks +23 lines, -24 lines 0 comments Download
M xfa/fde/css/fde_cssstyleselector.cpp View 6 chunks +13 lines, -14 lines 0 comments Download
M xfa/fde/css/fde_cssstylesheet.cpp View 1 5 chunks +13 lines, -13 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
Tom Sepez
Lei, Dan, ready for review.
3 years, 11 months ago (2017-01-05 01:27:42 UTC) #5
Tom Sepez
https://codereview.chromium.org/2616813002/diff/1/xfa/fde/css/cfde_cssrulecollection.cpp File xfa/fde/css/cfde_cssrulecollection.cpp (left): https://codereview.chromium.org/2616813002/diff/1/xfa/fde/css/cfde_cssrulecollection.cpp#oldcode128 xfa/fde/css/cfde_cssrulecollection.cpp:128: bool CFDE_CSSRuleCollection::AddRuleTo(FDE_CSSRuleData*& pList, note: insane, puts element into second ...
3 years, 11 months ago (2017-01-05 01:29:35 UTC) #6
dsinclair
lgtm
3 years, 11 months ago (2017-01-05 17:09:30 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2616813002/20001
3 years, 11 months ago (2017-01-05 17:09:34 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-05 17:09:53 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/e4d611c9c6d882bd47b6936554bdfc5c1ea6...

Powered by Google App Engine
This is Rietveld 408576698