Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1046)

Issue 2616743004: DevTools: Take subtitle into account when finding largest suggestion (Closed)

Created:
3 years, 11 months ago by einbinder
Modified:
3 years, 11 months ago
Reviewers:
pfeldman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Take subtitle into account when finding largest suggestion BUG=none Review-Url: https://codereview.chromium.org/2616743004 Cr-Commit-Position: refs/heads/master@{#441837} Committed: https://chromium.googlesource.com/chromium/src/+/03da338eac7d4a5a6327d42a657aec7852f04e01

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M third_party/WebKit/Source/devtools/front_end/ui/SuggestBox.js View 1 chunk +12 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
einbinder
ptal
3 years, 11 months ago (2017-01-05 19:58:08 UTC) #3
einbinder
ptal
3 years, 11 months ago (2017-01-05 19:58:08 UTC) #4
pfeldman
lgtm
3 years, 11 months ago (2017-01-06 00:11:06 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2616743004/1
3 years, 11 months ago (2017-01-06 00:27:12 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-06 02:36:25 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/03da338eac7d4a5a6327d42a657a...

Powered by Google App Engine
This is Rietveld 408576698