Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 2616743002: [turbofan] Fix shift_left/right in unittest (Closed)

Created:
3 years, 11 months ago by john.yan
Modified:
3 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix shift_left/right in unittest x86 automatically truncates the shift amount to be 5-bits. But not all architectures do that. R=rossberg@chromium.org, jarin@chromium.org, joransiu@ca.ibm.com, bjaideep@ca.ibm.com BUG= Review-Url: https://codereview.chromium.org/2616743002 Cr-Commit-Position: refs/heads/master@{#42099} Committed: https://chromium.googlesource.com/v8/v8/+/130e12d0208500ac0e7f97e089551251680348c6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M test/unittests/compiler/typer-unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
john.yan
ptal
3 years, 11 months ago (2017-01-04 22:45:38 UTC) #1
john.yan
ptal
3 years, 11 months ago (2017-01-05 17:28:12 UTC) #4
Benedikt Meurer
lgtm
3 years, 11 months ago (2017-01-05 18:25:29 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2616743002/1
3 years, 11 months ago (2017-01-05 18:41:58 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2017-01-05 18:43:38 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/130e12d0208500ac0e7f97e089551251680...

Powered by Google App Engine
This is Rietveld 408576698