media: Fix ENABLE_MOJO_MEDIA_IN_BROWSER_PROCESS check

media: Fix ENABLE_MOJO_MEDIA_IN_BROWSER_PROCESS check

Replace

 if (ENABLE_MOJO_MEDIA_IN_BROWSER_PROCESS)

with

 if defined(ENABLE_MOJO_MEDIA_IN_BROWSER_PROCESS)

The former was working because some compilers predefine FOO to be 1 when
-DFOO is specified. For example:
https://gcc.gnu.org/onlinedocs/gcc/Preprocessor-Options.html

But I am not sure whether this is true for all compilers. Hence we
probably should not depend on it.

Long term, we should switch to use BUILDFLAG to avoid this.

TBR=mkwst@chromium.org
BUG=596252
Review-Url: https://codereview.chromium.org/2616703005
Cr-Commit-Position: refs/heads/master@{#441782}
Committed: https://chromium.googlesource.com/chromium/src/+/59123b612a37738072b80870dfd18a7e8eaae241

[xhwang, 2017-01-05 19:59:26]

xhwang@chromium.org changed reviewers:
+ alokp@chromium.org

[xhwang, 2017-01-05 19:59:26]

minor cleanup/fix, PTAL

[alokp, 2017-01-05 20:53:13]

lgtm

[xhwang, 2017-01-05 21:32:43]

The CQ bit was checked by xhwang@chromium.org

[xhwang, 2017-01-05 21:32:44]

The CQ bit was unchecked by xhwang@chromium.org

[xhwang, 2017-01-05 21:33:31]

xhwang@chromium.org changed reviewers:
+ mkwst@chromium.org

[xhwang, 2017-01-05 21:33:32]

TBRing mkwst@chromium.org on trivial change in content/shell

[xhwang, 2017-01-05 21:33:41]

Description was changed from

==========
media: Fix ENABLE_MOJO_MEDIA_IN_BROWSER_PROCESS check

Replace

 if (ENABLE_MOJO_MEDIA_IN_BROWSER_PROCESS)

with

 if defined(ENABLE_MOJO_MEDIA_IN_BROWSER_PROCESS)

The former was working because some compilers predefine FOO to be 1 when
-DFOO is specified. For example:
https://gcc.gnu.org/onlinedocs/gcc/Preprocessor-Options.html

But I am not sure whether this is true for all compilers. Hence we
probably should not depend on it.

Long term, we should switch to use BUILDFLAG to avoid this.

BUG=596252
==========

to

==========
media: Fix ENABLE_MOJO_MEDIA_IN_BROWSER_PROCESS check

Replace

 if (ENABLE_MOJO_MEDIA_IN_BROWSER_PROCESS)

with

 if defined(ENABLE_MOJO_MEDIA_IN_BROWSER_PROCESS)

The former was working because some compilers predefine FOO to be 1 when
-DFOO is specified. For example:
https://gcc.gnu.org/onlinedocs/gcc/Preprocessor-Options.html

But I am not sure whether this is true for all compilers. Hence we
probably should not depend on it.

Long term, we should switch to use BUILDFLAG to avoid this.

TBR=mkwst@chromium.org
BUG=596252
==========

[xhwang, 2017-01-05 21:33:46]

The CQ bit was checked by xhwang@chromium.org

[commit-bot: I haz the power, 2017-01-05 21:34:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 01:19:47]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1483652026026280, "parent_rev":
"5ae4d2d504ad44943b99835f1eb7cba724318a97", "commit_rev":
"59123b612a37738072b80870dfd18a7e8eaae241"}

[commit-bot: I haz the power, 2017-01-06 01:20:13]

Description was changed from

==========
media: Fix ENABLE_MOJO_MEDIA_IN_BROWSER_PROCESS check

Replace

 if (ENABLE_MOJO_MEDIA_IN_BROWSER_PROCESS)

with

 if defined(ENABLE_MOJO_MEDIA_IN_BROWSER_PROCESS)

The former was working because some compilers predefine FOO to be 1 when
-DFOO is specified. For example:
https://gcc.gnu.org/onlinedocs/gcc/Preprocessor-Options.html

But I am not sure whether this is true for all compilers. Hence we
probably should not depend on it.

Long term, we should switch to use BUILDFLAG to avoid this.

TBR=mkwst@chromium.org
BUG=596252
==========

to

==========
media: Fix ENABLE_MOJO_MEDIA_IN_BROWSER_PROCESS check

Replace

 if (ENABLE_MOJO_MEDIA_IN_BROWSER_PROCESS)

with

 if defined(ENABLE_MOJO_MEDIA_IN_BROWSER_PROCESS)

The former was working because some compilers predefine FOO to be 1 when
-DFOO is specified. For example:
https://gcc.gnu.org/onlinedocs/gcc/Preprocessor-Options.html

But I am not sure whether this is true for all compilers. Hence we
probably should not depend on it.

Long term, we should switch to use BUILDFLAG to avoid this.

TBR=mkwst@chromium.org
BUG=596252

Review-Url: https://codereview.chromium.org/2616703005
Cr-Commit-Position: refs/heads/master@{#441782}
Committed:
https://chromium.googlesource.com/chromium/src/+/59123b612a37738072b80870dfd1...
==========

[commit-bot: I haz the power, 2017-01-06 01:20:14]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/59123b612a37738072b80870dfd1...