Remove CSSInitialValue::createLegacyImplicit()

Remove CSSInitialValue::createLegacyImplicit()

This patch removes the implicit initial value and changes all uses of it
to just use the regular initial value. We no longer have any code which
actually differentiates between implicit and non-implicit initial values
so this removal has no behaviour change.

There's still an implicit flag on CSSProperty, but this is currently
referenced by devtools. The flag seems to only be set when the repeat
longhands of background and -webkit-mask are set from the shorthand,
which doesn't really make sense. We should probably just remove the flag
too.

BUG=471917
Committed: https://crrev.com/d581bb3770e4e1102a30dbd25f90443c42b00052
Cr-Commit-Position: refs/heads/master@{#441587}

[Timothy Loh, 2017-01-05 03:27:31]

The CQ bit was checked by timloh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-05 03:27:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Timothy Loh, 2017-01-05 03:31:00]

timloh@chromium.org changed reviewers:
+ alancutter@chromium.org

[alancutter (OOO until 2018), 2017-01-05 03:36:58]

lgtm

[Timothy Loh, 2017-01-05 04:21:15]

The CQ bit was unchecked by timloh@chromium.org

[Timothy Loh, 2017-01-05 04:21:19]

The CQ bit was checked by timloh@chromium.org

[commit-bot: I haz the power, 2017-01-05 04:21:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-05 04:48:48]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1483590079795580, "parent_rev":
"2fa59ccace04105f4d45e92f837f449f4a88004c", "commit_rev":
"d6f76ad550e939501c205708567d0283cf2a863e"}

[commit-bot: I haz the power, 2017-01-05 04:49:26]

Description was changed from

==========
Remove CSSInitialValue::createLegacyImplicit()

This patch removes the implicit initial value and changes all uses of it
to just use the regular initial value. We no longer have any code which
actually differentiates between implicit and non-implicit initial values
so this removal has no behaviour change.

There's still an implicit flag on CSSProperty, but this is currently
referenced by devtools. The flag seems to only be set when the repeat
longhands of background and -webkit-mask are set from the shorthand,
which doesn't really make sense. We should probably just remove the flag
too.

BUG=471917
==========

to

==========
Remove CSSInitialValue::createLegacyImplicit()

This patch removes the implicit initial value and changes all uses of it
to just use the regular initial value. We no longer have any code which
actually differentiates between implicit and non-implicit initial values
so this removal has no behaviour change.

There's still an implicit flag on CSSProperty, but this is currently
referenced by devtools. The flag seems to only be set when the repeat
longhands of background and -webkit-mask are set from the shorthand,
which doesn't really make sense. We should probably just remove the flag
too.

BUG=471917

Review-Url: https://codereview.chromium.org/2616703004
==========

[commit-bot: I haz the power, 2017-01-05 04:49:27]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2017-01-05 04:51:34]

Description was changed from

==========
Remove CSSInitialValue::createLegacyImplicit()

This patch removes the implicit initial value and changes all uses of it
to just use the regular initial value. We no longer have any code which
actually differentiates between implicit and non-implicit initial values
so this removal has no behaviour change.

There's still an implicit flag on CSSProperty, but this is currently
referenced by devtools. The flag seems to only be set when the repeat
longhands of background and -webkit-mask are set from the shorthand,
which doesn't really make sense. We should probably just remove the flag
too.

BUG=471917

Review-Url: https://codereview.chromium.org/2616703004
==========

to

==========
Remove CSSInitialValue::createLegacyImplicit()

This patch removes the implicit initial value and changes all uses of it
to just use the regular initial value. We no longer have any code which
actually differentiates between implicit and non-implicit initial values
so this removal has no behaviour change.

There's still an implicit flag on CSSProperty, but this is currently
referenced by devtools. The flag seems to only be set when the repeat
longhands of background and -webkit-mask are set from the shorthand,
which doesn't really make sense. We should probably just remove the flag
too.

BUG=471917

Committed: https://crrev.com/d581bb3770e4e1102a30dbd25f90443c42b00052
Cr-Commit-Position: refs/heads/master@{#441587}
==========

[commit-bot: I haz the power, 2017-01-05 04:51:35]

Patchset 1 (id:??) landed as
https://crrev.com/d581bb3770e4e1102a30dbd25f90443c42b00052
Cr-Commit-Position: refs/heads/master@{#441587}