Add missing operator<() to CFX_RetainPtr

Add missing operator<() to CFX_RetainPtr.

Use std::less<>() rather than a direct ptr1 < ptr2 comparison to
be strictly correct in face of unspecified behaviour when ptr1 and
ptr2 don't point within the same "object" (e.g. segment of memory
on a brain-dead segmented architecture).

This will allow their use as keys in maps.

Review-Url: https://codereview.chromium.org/2616683002
Committed: https://pdfium.googlesource.com/pdfium/+/dc39e377e1a3923e63569020beb29f9662c1a3ee

[Tom Sepez, 2017-01-04 19:06:50]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-04 19:06:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2017-01-04 19:10:17]

Description was changed from

==========
Add missing operator<() to CFX_RetainPtr

BUG=
==========

to

==========
Add missing operator<() to CFX_RetainPtr.

Use std::less<>() rather than a direct ptr1 < ptr2 comparison to
be strictly correct in face of unspecified behaviour when ptr1 and
ptr2 don't point within the same "object" (e.g. segment of memory
on a brain-dead segmented architecture).
==========

[Tom Sepez, 2017-01-04 19:10:17]

tsepez@chromium.org changed reviewers:
+ dsinclair@chromium.org

[Tom Sepez, 2017-01-04 19:10:37]

Description was changed from

==========
Add missing operator<() to CFX_RetainPtr.

Use std::less<>() rather than a direct ptr1 < ptr2 comparison to
be strictly correct in face of unspecified behaviour when ptr1 and
ptr2 don't point within the same "object" (e.g. segment of memory
on a brain-dead segmented architecture).
==========

to

==========
Add missing operator<() to CFX_RetainPtr.

Use std::less<>() rather than a direct ptr1 < ptr2 comparison to
be strictly correct in face of unspecified behaviour when ptr1 and
ptr2 don't point within the same "object" (e.g. segment of memory
on a brain-dead segmented architecture).

This will allow their use as keys in maps.
==========

[Tom Sepez, 2017-01-04 19:11:05]

Dan, for review.

[commit-bot: I haz the power, 2017-01-04 19:19:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-04 19:19:49]

Dry run: This issue passed the CQ dry run.

[dsinclair, 2017-01-04 19:31:25]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2017-01-04 19:31:25]

lgtm

[commit-bot: I haz the power, 2017-01-04 19:31:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 19:31:48]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1483558285419260, "parent_rev":
"6745f96fab41e2b46f57a3717b034a4064c0de02", "commit_rev":
"dc39e377e1a3923e63569020beb29f9662c1a3ee"}

[commit-bot: I haz the power, 2017-01-04 19:31:50]

Description was changed from

==========
Add missing operator<() to CFX_RetainPtr.

Use std::less<>() rather than a direct ptr1 < ptr2 comparison to
be strictly correct in face of unspecified behaviour when ptr1 and
ptr2 don't point within the same "object" (e.g. segment of memory
on a brain-dead segmented architecture).

This will allow their use as keys in maps.
==========

to

==========
Add missing operator<() to CFX_RetainPtr.

Use std::less<>() rather than a direct ptr1 < ptr2 comparison to
be strictly correct in face of unspecified behaviour when ptr1 and
ptr2 don't point within the same "object" (e.g. segment of memory
on a brain-dead segmented architecture).

This will allow their use as keys in maps.

Review-Url: https://codereview.chromium.org/2616683002
Committed:
https://pdfium.googlesource.com/pdfium/+/dc39e377e1a3923e63569020beb29f9662c1...
==========

[commit-bot: I haz the power, 2017-01-04 19:31:51]

Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/dc39e377e1a3923e63569020beb29f9662c1...