Start removing UseSubframeNavigationEntries from tests.

Start removing UseSubframeNavigationEntries from tests.

This mode is always enabled now, so we can remove the code for handling
when it is disabled.  This CL starts with the easy cases in tests.

BUG=236848
TEST=Tests still pass.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/c1ff477d8444d341469e1f11a2606efff71b9588
Cr-Commit-Position: refs/heads/master@{#441445}

[Charlie Reis, 2017-01-04 18:09:12]

Description was changed from

==========
Start removing UseSubframeNavigationEntries from tests.

This mode is always enabled now, so we can remove the code for handling
when it is disabled.  This CL starts with the easy cases in tests.

BUG=236848
TEST=Tests still pass.
==========

to

==========
Start removing UseSubframeNavigationEntries from tests.

This mode is always enabled now, so we can remove the code for handling
when it is disabled.  This CL starts with the easy cases in tests.

BUG=236848
TEST=Tests still pass.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[Charlie Reis, 2017-01-04 18:16:38]

The CQ bit was checked by creis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-04 18:16:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Charlie Reis, 2017-01-04 18:42:09]

creis@chromium.org changed reviewers:
+ nasko@chromium.org

[Charlie Reis, 2017-01-04 18:42:09]

Getting started removing the old nav path!  I'm starting with the mechanical
cases in tests, since the old path has rotted a bit anyway (and crashes if you
use it).

https://codereview.chromium.org/2616673002/diff/1/content/browser/frame_host/...
File content/browser/frame_host/navigation_controller_impl_browsertest.cc
(right):

https://codereview.chromium.org/2616673002/diff/1/content/browser/frame_host/...
content/browser/frame_host/navigation_controller_impl_browsertest.cc:4985: if
(!SiteIsolationPolicy::UseSubframeNavigationEntries())
I left 3 of these in place, since they require a bit more thought.  I'll
update/remove them in a separate CL.

[commit-bot: I haz the power, 2017-01-04 18:55:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-04 18:55:11]

Dry run: This issue passed the CQ dry run.

[nasko, 2017-01-04 19:40:13]

Awesome to see the start of removing the old code. LGTM!

[Charlie Reis, 2017-01-04 19:41:46]

The CQ bit was checked by creis@chromium.org

[commit-bot: I haz the power, 2017-01-04 19:42:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 20:10:30]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1483558906523010, "parent_rev":
"22f470bea0ce35bdb81e82719832a2fb0689cb0f", "commit_rev":
"a4e8ae16402d2e566a4a53b3b12f368f71b9b6c5"}

[commit-bot: I haz the power, 2017-01-04 20:11:00]

Description was changed from

==========
Start removing UseSubframeNavigationEntries from tests.

This mode is always enabled now, so we can remove the code for handling
when it is disabled.  This CL starts with the easy cases in tests.

BUG=236848
TEST=Tests still pass.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Start removing UseSubframeNavigationEntries from tests.

This mode is always enabled now, so we can remove the code for handling
when it is disabled.  This CL starts with the easy cases in tests.

BUG=236848
TEST=Tests still pass.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2616673002
==========

[commit-bot: I haz the power, 2017-01-04 20:11:04]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2017-01-04 20:15:13]

Description was changed from

==========
Start removing UseSubframeNavigationEntries from tests.

This mode is always enabled now, so we can remove the code for handling
when it is disabled.  This CL starts with the easy cases in tests.

BUG=236848
TEST=Tests still pass.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2616673002
==========

to

==========
Start removing UseSubframeNavigationEntries from tests.

This mode is always enabled now, so we can remove the code for handling
when it is disabled.  This CL starts with the easy cases in tests.

BUG=236848
TEST=Tests still pass.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/c1ff477d8444d341469e1f11a2606efff71b9588
Cr-Commit-Position: refs/heads/master@{#441445}
==========

[commit-bot: I haz the power, 2017-01-04 20:15:14]

Patchset 1 (id:??) landed as
https://crrev.com/c1ff477d8444d341469e1f11a2606efff71b9588
Cr-Commit-Position: refs/heads/master@{#441445}