Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2616663003:
[MD Bookmarks] Add closure compilation to MD Bookmarks. (Closed)
|
Created:
3 years, 11 months ago by angelayang Modified:
3 years, 11 months ago CC:
chromium-reviews, vitalyp+closure_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, jlklein+watch-closure_chromium.org, dbeam+watch-closure_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[MD Bookmarks] Add closure compilation to MD Bookmarks.
BUG=658980
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2616663003
Cr-Commit-Position: refs/heads/master@{#442187}
Committed: https://chromium.googlesource.com/chromium/src/+/78c8556e215fe9def6cc73e31d36c8e43a4a157e
Patch Set 1 #
Total comments: 2
Patch Set 2 : Sort dependency. #
Messages
Total messages: 23 (17 generated)
Description was changed from ========== [MD Bookmarks] Add closure compilation to MD Bookmarks. BUG=658980 ========== to ========== [MD Bookmarks] Add closure compilation to MD Bookmarks. BUG=658980 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by angelayang@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Patchset #1 (id:1) has been deleted
The CQ bit was checked by angelayang@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== [MD Bookmarks] Add closure compilation to MD Bookmarks. BUG=658980 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== [MD Bookmarks] Add closure compilation to MD Bookmarks. BUG=658980 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
angelayang@google.com changed reviewers: + calamity@chromium.org
Please take a look? Thankyou
lgtm https://codereview.chromium.org/2616663003/diff/20001/chrome/browser/resource... File chrome/browser/resources/md_bookmarks/compiled_resources2.gyp (right): https://codereview.chromium.org/2616663003/diff/20001/chrome/browser/resource... chrome/browser/resources/md_bookmarks/compiled_resources2.gyp:35: '<(EXTERNS_GYP):bookmark_manager_private', Sort?
angelayang@google.com changed reviewers: + dbeam@chromium.org
https://codereview.chromium.org/2616663003/diff/20001/chrome/browser/resource... File chrome/browser/resources/md_bookmarks/compiled_resources2.gyp (right): https://codereview.chromium.org/2616663003/diff/20001/chrome/browser/resource... chrome/browser/resources/md_bookmarks/compiled_resources2.gyp:35: '<(EXTERNS_GYP):bookmark_manager_private', On 2017/01/05 03:01:58, calamity wrote: > Sort? Done.
lgtm
The CQ bit was checked by angelayang@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from calamity@chromium.org Link to the patchset: https://codereview.chromium.org/2616663003/#ps40001 (title: "Sort dependency.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1483920600827370,
"parent_rev": "4a496bb8248a82782841ecee92df37d3db00bb29", "commit_rev":
"78c8556e215fe9def6cc73e31d36c8e43a4a157e"}
Message was sent while issue was closed.
Description was changed from ========== [MD Bookmarks] Add closure compilation to MD Bookmarks. BUG=658980 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== [MD Bookmarks] Add closure compilation to MD Bookmarks. BUG=658980 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2616663003 Cr-Commit-Position: refs/heads/master@{#442187} Committed: https://chromium.googlesource.com/chromium/src/+/78c8556e215fe9def6cc73e31d36... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as https://chromium.googlesource.com/chromium/src/+/78c8556e215fe9def6cc73e31d36... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
