Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Unified Diff: ios/chrome/browser/ui/static_content/static_html_native_content.mm

Issue 2616633003: Fix crash in StaticHTMLNativeContent when deallocating WKWebView on iOS9 (Closed)
Patch Set: setDelegate in dealloc Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/browser/ui/reading_list/offline_page_native_content.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/ui/static_content/static_html_native_content.mm
diff --git a/ios/chrome/browser/ui/static_content/static_html_native_content.mm b/ios/chrome/browser/ui/static_content/static_html_native_content.mm
index bfaa5a8905ef033758733bc89b46719e8296ef61..cdf10615e69aa6c9f2355e38cf10384b888cff2b 100644
--- a/ios/chrome/browser/ui/static_content/static_html_native_content.mm
+++ b/ios/chrome/browser/ui/static_content/static_html_native_content.mm
@@ -68,6 +68,11 @@
URL:URL];
}
+- (void)dealloc {
+ [[self scrollView] setDelegate:nil];
+ [super dealloc];
+}
+
- (void)loadURL:(const GURL&)URL
referrer:(const web::Referrer&)referrer
transition:(ui::PageTransition)transition
@@ -85,6 +90,7 @@
- (void)setOverscrollActionsController:
(OverscrollActionsController*)controller {
_overscrollActionsController.reset([controller retain]);
+ [[self scrollView] setDelegate:controller];
}
#pragma mark -
« no previous file with comments | « ios/chrome/browser/ui/reading_list/offline_page_native_content.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698